[panva]

Update the updater script and files under deps/openssl/config in preparation for updating deps/openssl to OpenSSL 4.1.

blocked PRs that are blocked by other issues or PRs. until OpenSSL 4.1.0 releases.

Assisted-by: Codex

[nodejs-github-bot]

Review requested:

• @nodejs/gyp
• @nodejs/security-wg
• @nodejs/tsc

[aduh95]

blocked until OpenSSL 4.1.0 releases.

Wouldn't it make sense for 27.0.0-alpha to use the OpenSSL alpha beta version? I assume it would be smoother for users to adapt to a 4.1.0-beta2->4.1.0 bump than 3.5.x->4.1.0

[panva]

Test run 1 (d6a1eff): https://github.com/nodejs/node/actions/runs/38743272932
Resulting PR: #66762
Test run 2 (ff7beda): https://github.com/nodejs/node/actions/runs/38750162214
Test run 3 (60c7f9c): https://github.com/nodejs/node/actions/runs/38758207825

[panva]

Wouldn't it make sense for 27.0.0-alpha to use the OpenSSL alpha beta version? I assume it would be smoother for users to adapt to a 4.1.0-beta2->4.1.0 bump than 3.5.x->4.1.0

I wouldn't stress about it. That being said, if the test run goes well and PR gets opened and tests fine in GHA / Jenkins this would be good to go and you could in theory update main to 4.1.0+beta2 as semver-major with it.

[panva]

Update test itself is in a good shape AFAICT: #66762
Opened #66775 to deal with the new 4.1 prerelease test caveats and engine skips needed when 4.x is used.

[panva]

https://github.com/openssl/openssl/releases/tag/openssl-4.1.0

[panva]

going to run one more test run with 4.1.0

Run: https://github.com/nodejs/node/actions/runs/39953578902 (picked up openssl-4.1.0-beta2 prior to 2dbe4c6)
Run: https://github.com/nodejs/node/actions/runs/39958217606 (picked up openssl-4.1.0 🎉)
Test PR: #66959

[panva]

One more test run with #66775 in place: https://github.com/nodejs/node/actions/runs/39966109952
PR: #66960
CI: https://ci.nodejs.org/job/node-test-pull-request/78600/

[panva]

one new test failure needs accounting for a changed error code which we'll do in the actual update PR

---
duration_ms: 147.383
exitcode: 1
severity: fail
stack: |-
  node:internal/assert/utils:146
    throw error;
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + 'ERR_SSL_BAD_DECRYPT'
  - 'ERR_SSL_DECRYPTION_FAILED_OR_BAD_RECORD_MAC'
             ^

      at TLSSocket.<anonymous> (/home/iojs/build/workspace/node-test-commit-plinux/nodes/rhel10-ppc64le/test/parallel/test-tls-coalesce-records.js:120:16)
      at TLSSocket.<anonymous> (/home/iojs/build/workspace/node-test-commit-plinux/nodes/rhel10-ppc64le/test/common/index.js:512:15)
      at TLSSocket.emit (node:events:514:20)
      at TLSSocket._emitTLSError (node:internal/tls/wrap:1173:10)
      at TLSWrap.onerror (node:internal/tls/wrap:592:11) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: 'ERR_SSL_BAD_DECRYPT',
    expected: 'ERR_SSL_DECRYPTION_FAILED_OR_BAD_RECORD_MAC',
    operator: 'strictEqual',
    diff: 'simple'
  }

  Node.js v27.0.0-pre
...

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78604/

[nodejs-github-bot]

Landed in b12bad4