Repository navigation
quic: truncate CONNECTION_CLOSE frame reason field - #66644
Merged
nodejs-github-bot merged 4 commits intoOct 20, 2026
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Efe Karasakal <hi@efe.dev>
efekrskl
force-pushed
the
quic/truncate-close-reason
branch
from
October 10, 2026 12:38
8f2fdd1 to
63c637c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66644 +/- ##
==========================================
+ Coverage 90.43% 90.49% +0.06%
==========================================
Files 791 797 +6
Lines 276593 277598 +1005
Branches 53112 53330 +218
==========================================
+ Hits 250126 251204 +1078
+ Misses 16867 16800 -67
+ Partials 9600 9594 -6 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
efekrskl
added
the
quic
pimterry
reviewed
Oct 15, 2026
Signed-off-by: Efe Karasakal <hi@efe.dev>
pimterry
approved these changes
Oct 16, 2026
pimterry
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
pimterry
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
pimterry
added
commit-queue
Collaborator
|
Landed in 1a54c4f |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long reason strings inside a
CONNECTION_CLOSEframe could exceed the space available and crash the process.This PR limits the reason string to 256 UTF-8 bytes. Any string longer than the limit will get truncated. Also adds new tests and updates the documentation.
I think 256 bytes is a sensible default because the default maximum UDP datagram payload size is 1200 bytes. Before the handshake ngtcp2 can coalesce packets, encoding the same reason with 768 (3x256) bytes at most, this should leave enough headroom. This also matches Google QUICHE's limit