test: implement http test optimizations - #65926
Open
jasnell wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
needs-ci
mcollina
reviewed
Sep 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65926 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.01%
==========================================
Files 771 771
Lines 265470 265470
Branches 50463 50456 -7
==========================================
- Hits 239383 239367 -16
- Misses 17055 17059 +4
- Partials 9032 9044 +12 🚀 New features to boost your workflow:
|
jasnell
force-pushed
the
jasnell/http-test-time-fixes
branch
from
September 9, 2026 05:19
7db2aad to
e398ab4
Compare
Collaborator
jasnell
force-pushed
the
jasnell/http-test-time-fixes
branch
from
September 10, 2026 20:56
e398ab4 to
c45267a
Compare
aduh95
reviewed
Sep 10, 2026
aduh95
reviewed
Sep 10, 2026
Reviewing the performance of http tests in the smartos CI runs revealed that a handful of HTTP related tests are running way longer than they should, with some hitting upwards of 66 seconds! - Ten HTTP/HTTPS tests now close connections deterministically instead of waiting 66 seconds. - Two HTTP/2 tests use an explicit 64KiB stream window and 3MB payload, while restoring timeout assertions. - Estimated SmartOS CI saving: about 4.5 minutes at -j4. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
jasnell
force-pushed
the
jasnell/http-test-time-fixes
branch
from
September 10, 2026 22:35
c901e00 to
f4e2bf6
Compare
panva
approved these changes
Sep 11, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
pimterry
approved these changes
Sep 11, 2026
Member
|
A few more optimizations in #65980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewing the performance of http tests in the smartos CI runs revealed that a handful of HTTP related tests are running way longer than they should, with some hitting upwards of 66 seconds!