Skip to content

lib: put node:bench behind an --experimental-bench flag - #65920

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/node-bench-flag
Sep 12, 2026
Merged

lib: put node:bench behind an --experimental-bench flag#65920
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jasnell:jasnell/node-bench-flag

Conversation

@jasnell

@jasnell jasnell commented Sep 8, 2026

Copy link
Copy Markdown
Member

Stacks after #65919 .. the first commit here is from that

The second commit puts the experimental node:bench properly behind the --experimental-bench flag, which I completely missed on the initial landing.

@jasnell
jasnell requested review from ljharb and mcollina September 8, 2026 21:22
@jasnell jasnell added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. experimental Issues and PRs related to experimental features. labels Sep 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/loaders
  • @nodejs/performance
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 8, 2026
@jasnell jasnell mentioned this pull request Sep 8, 2026
Draft
@jasnell
jasnell force-pushed the jasnell/node-bench-flag branch from 7575fec to 79fa17e Compare September 8, 2026 21:32
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnell force-pushed the jasnell/node-bench-flag branch from 79fa17e to b3204fc Compare September 9, 2026 01:25
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77225/

@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 9, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 9, 2026
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@aduh95

This comment was marked as resolved.

Sign in to view
@meixg

This comment was marked as resolved.

Sign in to view
@jasnell jasnell mentioned this pull request Sep 9, 2026
Merged
@jasnell
jasnell force-pushed the jasnell/node-bench-flag branch from b3204fc to c27bdef Compare September 10, 2026 20:03
@jasnell jasnell added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 10, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnell force-pushed the jasnell/node-bench-flag branch from c27bdef to 2f039f1 Compare September 10, 2026 23:02
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

codecov Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.55224% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.98%. Comparing base (46bbfc4) to head (ae88c7e).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/node.cc 46.15% 7 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #65920   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files         784      784           
  Lines      268361   268416   +55     
  Branches    51117    51135   +18     
=======================================
+ Hits       241478   241539   +61     
+ Misses      17438    17437    -1     
+ Partials     9445     9440    -5
Files with missing lines Coverage Δ
lib/internal/bench_runner/cli.js 94.14% <100.00%> (+0.02%) ⬆️
lib/internal/bootstrap/realm.js 96.99% <100.00%> (+0.01%) ⬆️
lib/internal/process/pre_execution.js 97.41% <100.00%> (+0.03%) ⬆️
src/node_builtins.cc 77.66% <100.00%> (+0.07%) ⬆️
src/node_options.cc 80.58% <100.00%> (+0.41%) ⬆️
src/node_options.h 95.17% <100.00%> (-0.40%) ⬇️
src/node_worker.cc 82.30% <100.00%> (+0.01%) ⬆️
src/node.cc 75.96% <46.15%> (-0.40%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
lib: put node:bench behind an --experimental-bench flag
ae88c7e 
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
jasnell force-pushed the jasnell/node-bench-flag branch from 2f039f1 to ae88c7e Compare September 11, 2026 20:33
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 11, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77379/

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 12, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 12, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 12, 2026
@nodejs-github-bot
nodejs-github-bot merged commit dff7a16 into nodejs:main Sep 12, 2026
80 checks passed
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Landed in dff7a16

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
@panva panva panva approved these changes
@meixg meixg meixg approved these changes
@H4ad H4ad H4ad approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@mcollina mcollina Awaiting requested review from mcollina

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. c++ Issues and PRs that require attention from people who are familiar with C++. experimental Issues and PRs related to experimental features. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jasnell @nodejs-github-bot @aduh95 @meixg @ljharb @panva @H4ad @RafaelGSS @marco-ippolito