2026-09-09, Version 26.8.2 (Current) - #65917
Open
aduh95 wants to merge 77 commits into
Open
Conversation
Signed-off-by: Efe Karasakal <hi@efe.dev> PR-URL: #64342 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: Huáng Jùnliàng <jlhwung@gmail.com> PR-URL: #62352 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Currently, any runtime gated experimental feature security vulnerability is considered a "valid" vulnerability, even if the work is still very much work in progress. This adds friction because it ends up requiring that things be compile time gated which makes it more difficult if there is not a corresponding CI job to run tests. This relaxes the policy a bit. For anything that is 1.0 and 1.1, a vuln report is only valid if it directly compromises a stable feature, allows a workaround that compromises a stable feature, etc. An example would be an obvious DOS vector that can be exploited even if the feature is not enabled, for instance. This gives us leeway to reject vuln reports on things that are enabled only by `--experimental-*` runtime flag that are still works in progress. Given it's complexity and active development, give ourselves coverage by specifically excluding QUIC/H3 from vuln reports. Any vuln reports received for QUIC, unless it's something that can compromise security of something else in Node.js when the `--experimental-quic` runtime flag is not enabled, should be handled as regular issues and not as security vulns Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #65438 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Add contribution guidance and an advisory AgentScan warning for first-time pull request authors. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65533 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Document the lifecycle of node:test reporter events under Class: TestsStream, with an ASCII diagram that distinguishes declaration-order events from their execution-order twins (test:dequeue/test:complete), the leaf vs suite flow, and the run-level finale. Fixes: #51908 Signed-off-by: sangwook <rewq5991@gmail.com> PR-URL: #63780 Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65538 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: #65542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #65542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65542 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
It might increase the chance of them being scheduled. Refs: nodejs/build#4443 Refs: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#schedule Signed-Off-By: Michaël Zasso <targos@protonmail.com> PR-URL: #65612 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
These tests repeatedly fail across unrelated `main` PRs in the reliability reports from 2026-07-26 through 2026-08-26. Mark them flaky only on configurations where the failures were observed. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65562 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The stdio array note describes the stream passed for stdin as readable and stdout/stderr as writable, which is the reverse of the subprocess.stdin/subprocess.stdout streams created by 'pipe'. Readers keep conflating the two perspectives (see the linked issue and the self-closed PR #62175), so spell out the data flow and the contrast explicitly. Fixes: #56623 Signed-off-by: Avocado <ujubongbong@gmail.com> PR-URL: #65236 Fixes: #56623 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Updates the fsPromises.watch overflow option description to use 'error' instead of 'throw', which matches the implementation. Signed-off-by: Matt Radbourne <1254508+mradbourne@users.noreply.github.com> PR-URL: #64605 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The connection-callback comment claims triggerAsyncId() returns the asyncId of "conn". It actually returns the server's own triggerAsyncId, because the callback runs in the execution scope of the server's MakeCallback() — as the sibling executionAsyncId() example already explains. Mirror that comment. Fixes: #21078 Signed-off-by: Julian Soreavis <julian.soreavis@gmail.com> PR-URL: #64583 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The earlier version of the document contains duplications and has become logically disconnected after iteration. This patch wordsmiths it a bit to make it more coherent: - Merge policy points that have been repeated in the guidelines into the opening policy. - Remove redundant taglines. - Reword the paragraphs so that they appear more logical: -> decision making and accountability is human-only -> AI assistance is not prohibited -> disclosure and licensing -> verification and review requirement -> other off limits items (automation, good first issues) - Reword the guidelines to contextualize the suggestions with the use of AI instead of being generic. - Change the tone of the document to be more in line with other documents we have (e.g. avoid being too imperative or calling out "you" constantly) Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #65269 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Remove the base64 entry left behind when the dependency was removed, and rename the `ic` heading to `icu-small` so the TOC link resolves. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #65523 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
AIX can report lo0 as the scope ID for a datagram sent to a local interface. Validate that the received address includes a non-empty scope ID and verify that the address can be used to reply, instead of requiring the scope ID to match the destination interface. Refs: #46792 Assisted-by: Codex Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65629 Refs: #46792 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65583 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65592 Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #65494 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
The `#sec-using-declarations` fragment does not exist in the explicit resource management proposal, so the link silently resolves to the top of the page. The proposal defines `using` under `#sec-let-and-const-declarations`, and the only `using`-related section ids are static semantics entries. Point the reference at the MDN page for `using` instead, matching the `[`using`]` definition already used in fs.md. Signed-off-by: Soul Lee <alus20x@gmail.com> PR-URL: #65632 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Signed-off-by: hyemimi <hyemi7375@gmail.com> PR-URL: #65639 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: #65597 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
unofficial.gni special-cased ia32 on current_cpu while every other architecture used target_cpu. When node is also compiled in a host toolchain of a cross build (for example node_mksnapshot running in V8's snapshot toolchain, which is x86-hosted for 32-bit arm targets), current_cpu is the host's, so NODE_ARCH became "ia32" for an arm-targeted build and process.arch deserialized as 'ia32' on the device. Key the special case off target_cpu like the rest. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65491 Refs: electron/electron#52959 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
The previous deflake of this test, #63390, gave the two restart waits common.platformTimeout(10_000) and left the first restart() on the helper's 1000 ms default. That first call is the one still timing out on CI. It is also the call that needs the budget most. --watch spawns a child process to run the script, so reaching the first Completed running costs two process startups, while the later restarts pay for one. Wrapping the default in platformTimeout() would not have been enough on its own: none of its multipliers reaches a factor of ten, so the budget would still be 1000 ms on these jobs, or 2000 ms in a debug build. Give that call the budget the other two already ask for, stated once in the default rather than three times. The timer bounds how long the test waits for watch mode to make progress, it is not an assertion about restart latency, and the assertions on stdout and stderr are untouched. The same helper is duplicated in test-watch-mode.mjs, with the same default and nine call sites that take it. That file has carried PASS, FLAKY since #44898, which is why only this one surfaces in the reliability reports. Signed-off-by: Christian Aurich <christian.aurichzm@gmail.com> PR-URL: #65623 Refs: #63390 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-08-18.md Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-08-20.md Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-08-21.md Refs: #44898 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Use the Node.js GitHub bot token for association checks and route the welcome and caution messages independently. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65745 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Hamid Reza Ghavami <hamidr.ghavami@gmail.com> PR-URL: #65743 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Allows user to get `yamlllint` from other source than Pip (e.g. Nix). Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #65747 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.28.4 to 4.28.8. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.28.4...4.28.8) --- updated-dependencies: - dependency-name: browserslist dependency-version: 4.28.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #65758 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Bumps [@humanfs/node](https://github.com/humanwhocodes/humanfs/tree/HEAD/packages/node) from 0.16.7 to 0.16.8. - [Release notes](https://github.com/humanwhocodes/humanfs/releases) - [Changelog](https://github.com/humanwhocodes/humanfs/blob/main/packages/node/CHANGELOG.md) - [Commits](https://github.com/humanwhocodes/humanfs/commits/node-v0.16.8/packages/node) --- updated-dependencies: - dependency-name: "@humanfs/node" dependency-version: 0.16.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #65757 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sending a dgram socket over IPC duplicates the handle instead of moving it: `dgram.Socket` has no `postSend` in the child_process conversion table, and `bind()` calls `recvStart()` unconditionally, so the parent copy keeps consuming datagrams after the child adopts the handle. Both sockets then compete for every packet, and the child receives nothing until it wins that race. Locally the parent took up to 111 consecutive packets first, stretching the run to about 1.2s; the retry interval is the only thing keeping the test alive, and how long the parent can hold the socket is a property of the scheduler, not of the test. Close the parent copy as soon as the child reports it is receiving, so the child is the only reader by the time the first datagram is sent. Signed-off-by: Christian Aurich <christian.aurichzm@gmail.com> PR-URL: #65767 Refs: nodejs/reliability#1642 Refs: nodejs/reliability#1649 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
The second handle is only sent once the first one is acknowledged, by which time the worker may already have exited, so the write can fail with EPIPE. Observed on AIX in the CI reliability report of 2026-09-04. Signed-off-by: Christian Aurich <christian.aurichzm@gmail.com> PR-URL: #65770 Refs: nodejs/reliability#1650 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Add a ProfilerBinding declaration for
internalBinding('profiler') and wire it into InternalBindingMap.
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65660
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
test-https-proxy-request-invalid-char-in-url is the only client-proxy test that asserts the proxy logged no socket errors at all. Once the last response has been read the client destroys its tunnel, and if the proxy is still relaying the upstream's TLS close_notify at that point the client answers with a reset, which the proxy records as ECONNRESET on the CONNECT socket. That has been failing the test on macOS even though every request was routed to the sanitized URL. Keep asserting on other errors but leave connection resets out. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65780 Fixes: #64226 Refs: #59146 Refs: #54534 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
test-run-watch-emit-restarted expected exactly one test:watch:restarted
event, but it starts run({ watch: true }) right after writing the
fixtures into the watched directory. Watch backends that deliver events
with some latency, FSEvents on macOS most visibly, can still report
those setup writes once the first run is under way, which restarts it
and makes the later, intentional write the second restart. The test has
been marked flaky on macOS x64 for that reason.
Wait for the first drain, then require that the write is followed by a
restart and a drain, ignoring whatever the setup produced before it, and
drop the flaky marker.
Refs: #54534
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65780
Fixes: #64226
Refs: #59146
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
test-wasi-pthread fails now and then on every platform with "Assertion failed: r == 0 (c/pthread.c: main: 17)", i.e. pthread_create() itself reporting an error. The fixture implements `thread-spawn` by starting a Worker and blocking in Atomics.wait(result, 0, 0, 1000) until the worker signals that it has instantiated the module. Two things go wrong there: the worker signals success by storing 0, the value the main thread is already waiting on, so when the worker is quicker than the main thread its notify is lost and the wait runs into the timeout; and one second is not always enough for a Worker to start and instantiate a threads build on the slower CI hosts (arm debug, Windows, macOS). Either way spawn() returns -6 and wasi-libc turns that into a pthread_create() failure. Wait on a sentinel value that neither outcome writes, and give the worker a platform-scaled 30 seconds. Drop the flaky markers. Fixes: #64226 Refs: #59146 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #65780 Refs: #54534 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
test-dns-resolver-max-timeout times a query with `{ timeout: 500,
tries: 3 }` against one that also sets `maxTimeout: 500` and asserts
the first took longer. c-ares only expires a try when cares_wrap's
timer fires, every `timeout` ms, so each try costs one or two ticks
depending on sub-millisecond ordering, and uncapped retries also get
0.5-1x jitter. That leaves the capped run anywhere in 1500-3000 ms and
the uncapped one in 3000-4500 ms; on a busy rhel10-ppc64le host both
came out at 3005 ms. With `timeout: 100, tries: 5` the ranges (about
600-1000 ms and 5000-7500 ms measured under load) cannot meet.
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #65780
Fixes: #64226
Refs: #59146
Refs: #54534
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Add a StreamPipeBinding declaration for internalBinding('stream_pipe')
and wire it into InternalBindingMap.
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65664
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Add a FsEventWrapBinding declaration for
internalBinding('fs_event_wrap') and wire it into InternalBindingMap.
Signed-off-by: leah-1ee <selee3196@gmail.com>
PR-URL: #65661
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: leah-1ee <selee3196@gmail.com> PR-URL: #65661 Reviewed-By: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65788 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #65800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
aduh95
force-pushed
the
v26.8.2-proposal
branch
from
September 8, 2026 20:25
6a7f519 to
f2f2c2f
Compare
Collaborator
Contributor
Changelog@@ -486,0 +487,4 @@
+/nix/store/hjr35k1yq2f7rm3j5hmxn8gb6za4557r-jemalloc-5.3.0-unstable-2025-09-12 (aarch64-darwin)
+/nix/store/01sxs0dygizxrpi68ns4ch3gdv25vilj-jemalloc-5.3.0-unstable-2025-09-12 (aarch64-linux)
+/nix/store/8f7ndm2gn04xa7089iikd77qycypfvy8-jemalloc-5.3.0-unstable-2025-09-12 (x86_64-darwin)
+/nix/store/fpf6nabl7s37fxyx4f27mmnxcwazbbrj-jemalloc-5.3.0-unstable-2025-09-12 (x86_64-linux)
@@ -838,0 +843,4 @@
+/nix/store/xya4zy2f463yfzipmxvy2pxm5b1gw0m4-libyaml-0.2.5 (aarch64-darwin)
+/nix/store/z27lhbwzcx0zjn3wjqv797rnw5m486j9-libyaml-0.2.5 (aarch64-linux)
+/nix/store/dvarchpp13i33rm7acxjldsajlpk0d4p-libyaml-0.2.5 (x86_64-darwin)
+/nix/store/5by3i4053gppzf3ci7ygv1mj8gjhp6mk-libyaml-0.2.5 (x86_64-linux)
@@ -1520,0 +1529,16 @@
+/nix/store/iblkhb2ma6kzfp4h18yk7m9dc8wgh9jy-python3.13-pathspec-0.12.1 (aarch64-darwin)
+/nix/store/jk4fd3xp3pb6mv320lx9zpbwxdbibp6i-python3.13-pathspec-0.12.1 (aarch64-linux)
+/nix/store/3x5srsy0agan4d1jqizkbn7ws14gxl45-python3.13-pathspec-0.12.1 (x86_64-darwin)
+/nix/store/pdjdz9mqsj6az0znlrgh2fj6wp1rb032-python3.13-pathspec-0.12.1 (x86_64-linux)
+/nix/store/2hipkj74d1jkh5y0fl0zq3w50b0mq39c-python3.13-pyyaml-6.0.3 (aarch64-darwin)
+/nix/store/p8sajismwcq0jc23g6jmbablbwj22hzj-python3.13-pyyaml-6.0.3 (aarch64-linux)
+/nix/store/gajdg005yjbw5x9lbf4ldc5cm38ml7hn-python3.13-pyyaml-6.0.3 (x86_64-darwin)
+/nix/store/jl0mxihyizv77l66mzbvmv49iiri72sd-python3.13-pyyaml-6.0.3 (x86_64-linux)
+/nix/store/0yhwlrn6j4bpk8pqz0p5a53ml2a1h00v-python3.13-yamllint-1.37.1 (aarch64-darwin)
+/nix/store/m9g8qnggdzc6pjdw7w21vaywmlix2ccn-python3.13-yamllint-1.37.1 (aarch64-linux)
+/nix/store/s7aj93h2895lmyk13c6ypn22rsd6nf36-python3.13-yamllint-1.37.1 (x86_64-darwin)
+/nix/store/jx6bzribg9fa0mxbr8b602rq74k24dr7-python3.13-yamllint-1.37.1 (x86_64-linux)
+/nix/store/32s4c8qgg8lch0y6k4cqxs09qkyazjw9-python3.13-yamllint-1.37.1-dist (aarch64-darwin)
+/nix/store/14lw229a8sjsbfjvjj97b3m0jc11q147-python3.13-yamllint-1.37.1-dist (aarch64-linux)
+/nix/store/xx2yyh67vr217s8iv5gmkdhsibmqrdrw-python3.13-yamllint-1.37.1-dist (x86_64-darwin)
+/nix/store/sdyqiyd0aw6n3fv2fj33srgvqi779rsp-python3.13-yamllint-1.37.1-dist (x86_64-linux)
@@ -1608,0 +1633,4 @@
+/nix/store/vaqnnrhxwmj73hwn8jwcs1q6ix17fd2k-ruff-0.15.12 (aarch64-darwin)
+/nix/store/b4hb3zim99khxjl4ncliy5pm9gzkq9ba-ruff-0.15.12 (aarch64-linux)
+/nix/store/wbrlvj0zkrchsnwyd0l6s36nzvfpq9hm-ruff-0.15.12 (x86_64-darwin)
+/nix/store/97mrhz21xc7dx218i36m6s9jyi7q5469-ruff-0.15.12 (x86_64-linux) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v26.x #65917 +/- ##
==========================================
- Coverage 90.40% 90.39% -0.02%
==========================================
Files 744 744
Lines 250463 250463
Branches 47793 47786 -7
==========================================
- Hits 226437 226398 -39
- Misses 15338 15350 +12
- Partials 8688 8715 +27 🚀 New features to boost your workflow:
|
Collaborator
richardlau
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
616bd3fa26] - doc: deprecateServer.prototype._listen2innode:net(Antoine du Hamel) #65593ae1801eb55] - meta: refine the security vuln posture for experimental features (James M Snell) #6543809feba74c8] - deps: update Undici to 8.10.2 (Node.js GitHub Bot) #657887efdbe3eb9] - deps: update OpenSSL to 3.5.8 (Node.js GitHub Bot) #65542Commits
d8aedd6584] - build: skip dockit on riscv64 (Stewart X Addison) #622511899c274eb] - build: activate correct default flags for riscv64 (Stewart X Addison) #65708ec8a3be996] - build: derive NODE_ARCH from target_cpu in the GN build (Shelley Vohr) #65491b73118a507] - build,win: remove LTO parallelisation limit (Stefan Stojanovic) #6553509feba74c8] - deps: update undici to 8.10.2 (Node.js GitHub Bot) #65788e47c432dd6] - deps: upgrade npm to 11.19.1 (npm team) #655732fd6ce36a9] - deps: update corepack to 0.36.0 (Node.js GitHub Bot) #6565349dec2767a] - deps: update googletest to 36ba75f0ad5383a9759f17f3f72fd4661c72cb6d (Node.js GitHub Bot) #65654676174a071] - deps: update simdjson to 4.6.9 (Node.js GitHub Bot) #656552f1b7fa0bb] - deps: update perfetto to 58.2 (Node.js GitHub Bot) #6565612acd0ad15] - deps: update zlib to 1.3.2.1-motley-5eb4d7e (Node.js GitHub Bot) #6549448631c80fb] - deps: update archs files for openssl-3.5.8 (Node.js GitHub Bot) #655427efdbe3eb9] - deps: upgrade openssl sources to openssl-3.5.8 (Node.js GitHub Bot) #65542bdc75900ee] - doc: replacenode:modulesdocumentation header (René) #6580044c8a499ba] - doc: clarify return type offs.mkdtemp*(Antoine du Hamel) #65743025fb5eeb0] - doc: updatechangelog-makerinstructions for releasing (Juan José) #657075f64847afa] - doc: add stability status tocrypto.setEngine(Antoine du Hamel) #65746299dee0cb9] - doc: remove outdated TLS authorized warning (Tim Perry) #65597e97dcc0278] - doc: fix brokenusinglink in ffi.md (Soul Lee) #656322c9cc7d237] - doc: fix some broken links (Antoine du Hamel) #655830c330ec329] - doc: fix stale TOC in maintaining-dependencies (greenhead) #655239c522a3a69] - doc: refactor the AI guidelines (Joyee Cheung) #6526946cbf1bf8c] - doc: fix triggerAsyncId() comment in async_hooks example (soreavis) #64583788904ff78] - doc: fix fsPromises.watch overflow value (Matt Radbourne) #646053d06ff19e8] - doc: clarify stream direction in options.stdio note (Avocado) #65236d334838379] - doc: clarify signal listener behavior (Som Samantray) #65243d55a2bd56a] - doc: add test reporter event lifecycle diagram (sangwook) #63780c17dfc87de] - doc: discourage AbortSignal cleanup for long-lived resources (Efe Karasakal) #64342616bd3fa26] - doc: deprecateServer.prototype._listen2innode:net(Antoine du Hamel) #655934e6d7e0ca6] - meta: cleanup targos emeritus changes (Antoine du Hamel) #65738a70cfe1747] - meta: bump github/codeql-action/init from 4.37.3 to 4.37.9 (dependabot[bot]) #65714e43a0ad4ce] - meta: bump github/codeql-action/autobuild from 4.37.3 to 4.37.9 (dependabot[bot]) #6571799e06288f1] - meta: bump actions/checkout from 7.0.0 to 7.0.1 (dependabot[bot]) #6571889662762b3] - meta: bump cachix/install-nix-action from 31.11.0 to 31.11.1 (dependabot[bot]) #657196b8f078672] - meta: bump actions/setup-node from 6.4.0 to 7.0.0 (dependabot[bot]) #657206c6fb18e63] - meta: bump step-security/harden-runner from 2.20.0 to 2.21.0 (dependabot[bot]) #657210e002e859f] - meta: bump github/codeql-action/upload-sarif from 4.37.3 to 4.37.9 (dependabot[bot]) #6572298aaffe4b9] - meta: bump github/codeql-action/analyze from 4.37.3 to 4.37.9 (dependabot[bot]) #65723d247cb2975] - meta: document collaborator automation (Filip Skokan) #65671ae1801eb55] - meta: refine the security vuln posture for experimental features (James M Snell) #65438fab81d15c3] - test: widen the gap in the resolver maxTimeout comparison (Shelley Vohr) #6578062e2a6265c] - test: fix the thread-spawn handshake in the WASI threads fixture (Shelley Vohr) #657807eb20b1810] - test: only count restarts after the write in watch emit-restarted test (Shelley Vohr) #6578014c3a77bc5] - test: ignore tunnel resets in proxy invalid-char-in-url test (Shelley Vohr) #65780ebc99e0560] - test: handle EPIPE in closed channel test (Christian Aurich) #657705e73a2ca79] - test: deflake test-permission-net-udp-handle (Christian Aurich) #65767beb669f7de] - test: deflake test-runner-coverage (Christian Aurich) #65728ef4b6bfa62] - test: set type=none on IBM i for empty source (Abdirahim Musse) #65545027eef0691] - test: deflake WASI poll timing checks (Filip Skokan) #65672a352b0e2fe] - test: skipfs-watch-recursive-delete-raceon AIX (Antoine du Hamel) #65698f9ce35aa43] - test: deflake test-inspect-async-hook-setup-at-inspect (Christian Aurich) #6558432281cec7b] - test: deflake test-watch-mode-restart-esm-loading-error (Christian Aurich) #6562379be5d61be] - test: avoid orphaned child on Windows abort test (Kirill Saied) #654518972b8540b] - test: fix link-local dgram scope assertion (Filip Skokan) #65629b7cd1d96de] - test: riscv64: skip node-api sea test (Stewart X Addison) #655697eeb9d0e57] - test: mark platform-specific tests as flaky (Filip Skokan) #65562649ac82bda] - test: account for varied OpenSSL CCM final behaviours (Filip Skokan) #65542050fb1a15d] - tools: bump @humanfs/node from 0.16.7 to 0.16.8 in /tools/eslint (dependabot[bot]) #657575314dda396] - tools: bump browserslist from 4.28.4 to 4.28.8 in /tools/eslint (dependabot[bot]) #657585938a08929] - tools: do not hardcodeyamllintpath (Antoine du Hamel) #65747d8408f7415] - tools: refine contributor guidance workflow (Filip Skokan) #65745196e372b69] - tools: bump the eslint group in /tools/eslint with 4 updates (dependabot[bot]) #657167e986b09f6] - tools: do not flag force push as invalid message (Antoine du Hamel) #65700837ce2ccef] - tools: do not hardcode path to Ruff (Antoine du Hamel) #656811c7149a96a] - tools: retry first-time contributor query (Filip Skokan) #65648bd310a2bea] - tools: query first-time contributor status (Filip Skokan) #65592ab7b57e547] - tools: offset GitHub crons by 3 minutes (Michaël Zasso) #6561262ece28eae] - tools: label PRs lacking second approval (Filip Skokan) #6553868227b4029] - tools: welcome first-time contributors (Filip Skokan) #65533490dc93e37] - tools: enable concurrency for eslint (Huáng Jùnliàng) #62352d794676217] - typings: fix fs_event_wrap start filename type (leah-1ee) #6566129e2b5a325] - typings: add fs_event_wrap internal binding types (leah-1ee) #656616357c8f56e] - typings: add stream_pipe internal binding types (Seongeun Lee) #65664569720ac7f] - typings: add profiler internal binding types (Seongeun Lee) #6566052ae89c69d] - typings: add ffi internal binding types (Donghoon Kang) #6573422c7469062] - typings: update zlib binding declarations (이혜미) #65639