Skip to content

src,doc,test: gate alpha version tag behind a macro - #65567

Open
lazerg wants to merge 1 commit into
nodejs:mainfrom
lazerg:fix/issue-65566-alpha-tag
Open

src,doc,test: gate alpha version tag behind a macro#65567
lazerg wants to merge 1 commit into
nodejs:mainfrom
lazerg:fix/issue-65566-alpha-tag

Conversation

@lazerg

@lazerg lazerg commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

NODE_ALPHA_MAJOR_VERSION is always defined, so the #ifdef guard around the alpha tag was true for every release build and v26.8.0 shipped as v26.8.0-alpha.0.0.0. The tag now hangs off a separate NODE_VERSION_IS_ALPHA flag, mirroring how NODE_VERSION_IS_LTS works, so a stable line just leaves the flag at 0 rather than relying on the three alpha macros being deleted. test-release-changelog also checks process.version against the macros now, and that runs on release proposals where the release bit is set.

This on its own won't fix the shipped binaries, v26.x still needs a backport and a new patch release.

Fixes: #65566

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 26, 2026
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
@lazerg
lazerg force-pushed the fix/issue-65566-alpha-tag branch from ccce945 to 68ebf14 Compare August 26, 2026 16:20
@lazerg lazerg changed the title src,doc: gate alpha version tag behind a macro src,doc,test: gate alpha version tag behind a macro Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (a00cf06) to head (68ebf14).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65567      +/-   ##
==========================================
- Coverage   90.07%   90.07%   -0.01%     
==========================================
  Files         751      751              
  Lines      254778   254737      -41     
  Branches    48089    48067      -22     
==========================================
- Hits       229494   229456      -38     
- Misses      16464    16475      +11     
+ Partials     8820     8806      -14     

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95

aduh95 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

I'm not sure this is helping, instead of having 3 macros we'd have 4 🤔 I don't think it's making it less likely to slip into a non-alpha release either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node v26.8.0 reporting version as alpha

3 participants