Skip to content

[docs]: add example data for compatible models - #427

Merged
Schiano-NOAA merged 6 commits into
mainfrom
docs-pkg-ex-data
Oct 30, 2026
Merged

Schiano-NOAA merged 6 commits into
mainfrom
docs-pkg-ex-data

Conversation

@Schiano-NOAA

Copy link
Copy Markdown
Collaborator

Adding example data for each model compatible with convert_output()

repository: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name || github.repository }}
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || github.ref_name }}

- uses: r-lib/actions/setup-r@v2
with:
use-public-rspm: true

- uses: r-lib/actions/setup-r-dependencies@v2
@Schiano-NOAA
Schiano-NOAA added this pull request to stack #430 October 19, 2026 20:32
@github-actions

Copy link
Copy Markdown
Contributor

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
75.3% 1:0.2 6m25s

Reported by octocov

Comment thread data-raw/DATASET_RCEATTLE.R Resolved
Comment thread data-raw/DATASET_SS3-r4ss.R Resolved
Comment thread inst/extdata/VermilionSnapper.rdat Resolved

@sbreitbart-NOAA sbreitbart-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to discuss and adjust before merging. Thanks for getting this started- it'll definitely make the package stronger!

@Schiano-NOAA Schiano-NOAA mentioned this pull request Oct 28, 2026
@Schiano-NOAA Schiano-NOAA linked an issue Oct 28, 2026 that may be closed by this pull request
@Schiano-NOAA

Copy link
Copy Markdown
Collaborator Author

@sbreitbart-NOAA are you good with me merging after addressing your comments?

@Schiano-NOAA

Schiano-NOAA commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator Author

@sbreitbart-NOAA I believe all comments have now been addressed within one of the three branches. Good to go?

I think the checks will fail due to the plot_spr issue that will be fixed with merge of #433

@sbreitbart-NOAA
sbreitbart-NOAA self-requested a review October 30, 2026 13:41

@sbreitbart-NOAA sbreitbart-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if my comments have been addressed, LGTM!

@Schiano-NOAA
Schiano-NOAA merged commit 896c58a into main Oct 30, 2026
5 of 8 checks passed
@Schiano-NOAA
Schiano-NOAA deleted the docs-pkg-ex-data branch October 30, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update SS3 tests

3 participants