Repository navigation
[docs]: add example data for compatible models - #427
Merged
Merged
Conversation
| repository: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name || github.repository }} | ||
| ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.ref || github.ref_name }} | ||
|
|
||
| - uses: r-lib/actions/setup-r@v2 |
| with: | ||
| use-public-rspm: true | ||
|
|
||
| - uses: r-lib/actions/setup-r-dependencies@v2 |
Contributor
Code Metrics Report
Reported by octocov |
sbreitbart-NOAA
requested changes
Oct 21, 2026
sbreitbart-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
A few things to discuss and adjust before merging. Thanks for getting this started- it'll definitely make the package stronger!
Schiano-NOAA
force-pushed
the
docs-pkg-ex-data
branch
from
October 22, 2026 13:48
8bdc4ca to
37c5cec
Compare
Closed
Closed
Collaborator
Author
|
@sbreitbart-NOAA are you good with me merging after addressing your comments? |
Schiano-NOAA
force-pushed
the
docs-pkg-ex-data
branch
from
October 29, 2026 17:53
37c5cec to
a5c3f05
Compare
Collaborator
Author
|
@sbreitbart-NOAA I believe all comments have now been addressed within one of the three branches. Good to go? I think the checks will fail due to the plot_spr issue that will be fixed with merge of #433 |
sbreitbart-NOAA
self-requested a review
October 30, 2026 13:41
sbreitbart-NOAA
approved these changes
Oct 30, 2026
sbreitbart-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
Yes, if my comments have been addressed, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding example data for each model compatible with
convert_output()