Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Fix installer creation for macOS 27 Golden Gate — incorrect Installer app path
Project:
ninxsoft/Mist(GUI app)Fixes: #241
Scope:
Mist/Model/Installer.swiftonly (1 file, +9 / -1)Summary
Mist was trying to use the installer application bundle at
<mount>/Applications/Install macOS Golden Gate.app, but Apple'sInstallAssistant.pkgfor macOS 27 now creates the bundle asInstall macOS 27 Golden Gate.app(the major version is part of the name,unlike previous releases such as
Install macOS Tahoe.app). As a result,creating installers (bootable installer,
.iso) fails to locatecreateinstallmedia.Root cause
The GUI's
Installer.namecomputed property maps version^27to the displayname
macOS Golden Gate(no version number), andtemporaryInstallerURLbuiltthe bundle path as
Install \(name).app→Install macOS Golden Gate.app.Apple names the 27.x bundle
Install macOS 27 Golden Gate.app, so the derivedpath points at a file that does not exist.
Note:
mist-cliwas not affected — itsnameis parsed from Apple'sdistribution file and already resolves to
macOS 27 Golden Gate, so no CLIchange is required.
Change
Add an
applicationNamecomputed property that returns the actual on-diskbundle name, branching on the existing version-regex idiom used throughout the
codebase:
temporaryInstallerURLnow derives the bundle name fromapplicationName,so every downstream consumer (bootable installer,
.iso,.app/.dmgcopy targets) resolves the correct path.
Verification
volume is exactly
Applications/Install macOS 27 Golden Gate.app.swiftccheck of the derived property:27.0/27.1→Install macOS 27 Golden Gate26.7→Install macOS Tahoe(regression check)15.8→Install macOS Sequoia(regression check)temporaryInstallerURL.lastPathComponent→Install macOS 27 Golden Gate.appswiftlint --strict— no violations in the changed fileswiftformat --lint .— 0 files require formattingdrstring check— cleanxcodebuild— BUILD SUCCEEDED (Debug,CODE_SIGNING_ALLOWED=NO)xcodebuild test -scheme MistTests— TEST SUCCEEDEDswift test— all passedNotes / limitations
separately by the existing beta-rename tasks and is unchanged.
optional_data_string_conversionlint violations exist inShellExecutor.swift,Hardware.swift,RefreshView.swiftandPropertyListUpdater.swift; they are not introduced by this PR and do notfail CI's pinned SwiftLint (0.63.x).
AI assistance
This change was implemented with AI assistance.
Checklist
MistGUI)mist-clidocumented (no change required)