Skip to content

Fix hover label of plugin function calls - #198

Merged
bentsherman merged 1 commit into
mainfrom
plugin-function-hover
Oct 30, 2026
Merged

bentsherman merged 1 commit into
mainfrom
plugin-function-hover

Conversation

@bentsherman

Copy link
Copy Markdown
Member

Hovering over a call to a plugin function showed a stray ? and the generic declaration of the return type:

? samplesheetToList(samplesheet: String, schema: String) -> List<E>

Now it shows:

samplesheetToList(samplesheet: String, schema: String) -> List
  • ScriptSpecFactory creates raw types for type names in the spec (List), instead of reusing the generic declaration (List<E>).
  • The hover label omits the declaring type when it is dynamic, which is the case for plugin functions. Before, it was printed as ?.

Testing

@bentsherman
bentsherman merged commit 97ba2b7 into main Oct 30, 2026
7 checks passed
@bentsherman
bentsherman deleted the plugin-function-hover branch October 30, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant