Repository navigation
Added intermediate for the takes and emits for the subworkflow nodes - #151
Open
George-Marchment wants to merge 6 commits into
Open
George-Marchment wants to merge 6 commits into
George-Marchment wants to merge 6 commits into
Conversation
Add/remove methods in shim types
Add an opt-in expandWorkflowCalls flag to DataflowVisitor, which expands each subworkflow call into a take node per argument, the call node, and an emit node per emit. Emit nodes are tracked per call, so FOO.out.x resolves to the emit of the call currently bound to FOO. Label control nodes with the source text of their condition, read from the compiled source unit. Based on the work of George Marchment in nextflow-io#151.
Supersede the original implementation with the rewrite on current main.
Member
|
Thanks George! The language server core was rewritten since this PR was opened ( What changedExpanding subworkflow calls into take and emit nodes
Condition text
Tests
|
Member
|
Parking until we can test a full vs code <-> metromap integration, so that I can better understand what is required in the DAG |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the functionctionnalities i've added