Repository navigation
Support Nextcloud 35 - #409
Merged
Merged
Conversation
Symfony Console 7, which 35 ships, requires Command::execute() to declare an int return type; without it the two occ commands here fatal on boot. Declares it on both, bumps the compatibility range, and moves the rig and the phpunit workflow onto 35 and a connector release that supports it (10.1.2 tops out at 34). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Fabrice Meyer <meyer.fabrice@gmx.fr>
chadek
force-pushed
the
support-nextcloud-35
branch
from
October 17, 2026 19:35
0ff97a7 to
dc52f80
Compare
chadek
added a commit
that referenced
this pull request
Oct 17, 2026
Nextcloud 35 support (#409): the two occ commands here declared execute() without the int return type Symfony Console 7 requires, which faults app boot on 35. No migration carries this one, but the appstore push expects a version that moved. Signed-off-by: Fabrice Meyer <meyer.fabrice@gmx.fr> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appinfo/info.xml).Command::execute()to declare anintreturn type; without itFlushChangesandFontsfatal on boot with a "Declaration must be compatible" error. Both now declare it.nextcloud:35.0.2-apacheand the pinned ONLYOFFICE connector to 10.2.1, the first release that declares support for 35 (10.1.2 tops out at 34 and refuses to install).nextcloud/servercheckout atstable35, the newest releaseinfo.xmlnow declares support for.Test plan
tests/rigend to end againstnextcloud:35.0.2-apachewith connector 10.2.1: rig up, provision (both apps enabled), full regression suite via./rig.sh test --keep-going.php -lon the two edited command classes.stable35, lint, integration) on this PR.🤖 Generated with Claude Code