Repository navigation
Conversation
cbrnr
requested review from
camilasan,
claucambra,
i2h3,
mgallien and
nilsding
as code owners
November 3, 2026 07:58
…cOS and Linux Match the capitalization of the platform human interface guidelines for context menu entries on macOS and Linux. Windows keeps sentence case. - File provider extensions: rename the Info.plist labels together with their Localizable.xcstrings keys and English values, so existing translations are still found. - Socket API menu (Finder Sync, Dolphin, Nautilus): choose the string per platform at the source instead of mapping it in each integration. - Virtual files pin and free space actions and the GNOME cloud provider menu entry. - Add a test which checks the labels of both file provider extensions against their string catalogs, and a test for the virtual files action texts. The Qt changes and the new Qt test have not been built or run locally. Closes nextcloud#10525 Assisted-by: ClaudeCode:claude-sonnet-5-5 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Clemens Brunner <clemens.brunner@gmail.com>
cbrnr
force-pushed
the
fix/title-case-context-menu-macos
branch
from
November 3, 2026 08:02
b4905a3 to
5c410ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
#10525 (supersedes #10581)
Summary
Context menu entries now use title case on macOS and Linux; Windows keeps sentence case. These are the changes:
FileProviderExtandFileProviderUIExtare title-cased. TheInfo.plistlabel, catalog key and English values are all changed together.socketapi.cpp, so none of those integrations needs its own mapping.A follow-up PR could change the entries in the tray menu ("Add account", "More activity...", "Pause sync for all"/"Resume sync for all". This PR is just about the context menu.
Checklist
AI (if applicable)