Repository navigation
Conversation
| Status _status BITFIELD(4); | ||
| bool _isRestoration BITFIELD(1); // The original operation was forbidden, and this is a restoration | ||
| bool _isSelectiveSync BITFIELD(1); // The file is removed or ignored because it is in the selective sync list | ||
| bool _keptLocalOnlyData BITFIELD(1); // The upload was ignored, and the local-only data was kept on disk (new item in a read-only folder) |
There was a problem hiding this comment.
I would call it _isReadOnly
I think it tells more about the item than _keptLocalOnlyData
There was a problem hiding this comment.
@camilasan It's not the read only item/file :)
The read only items are the OTHER files in that directory that come from the server.
This is the (new) item that was (locally on desktop) copied by the user into the read only FOLDER.
And (before the original fix) it was deleted by the sync engine. Now it is kept (hence the name) by the sync engine so the user has a chance to rescue the file.
I'm open to other names if you don't like _keptLocalOnlyData.
There was a problem hiding this comment.
side note: The test case in testpermissions.cpp (of my original PR) is also called testNewLocalFileInReadOnlyFolderIsKept
There was a problem hiding this comment.
got it, what about _isUploadForbidden?
There was a problem hiding this comment.
Shall we mix it to _isUploadForbiddenFileKept?
There was a problem hiding this comment.
or maybe Item instead of File
There was a problem hiding this comment.
yes, I think that should work. thanks!
| // The item could not be uploaded (it lives in a read-only folder) and its | ||
| // local-only data was kept on disk. Unlike other ignored items this is shown | ||
| // in the Not-synced list so the user can see why it never syncs. |
There was a problem hiding this comment.
if you rename _keptLocalOnlyData to something more clear, this whole comments could be removed.
…ored file This is a followup to nextcloud#10226 Introduces a proper flag for this read-only remote folder case. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Markus Goetz <markus@woboq.com>
5bfb9cd to
9a7ac17
Compare
Resolves
Summary
Followup to @v3DJG6GL comment.
Checklist
AI (if applicable)