Skip to content

fix(deps): require certifi 2026.10.19 or later - #117

Merged
mfiedorowicz merged 1 commit into
developfrom
chore/certifi-2026.10.19
Oct 21, 2026
Merged

mfiedorowicz merged 1 commit into
developfrom
chore/certifi-2026.10.19

Conversation

@mfiedorowicz

Copy link
Copy Markdown
Member

The SDK verifies gRPC and HTTPS peers against the certifi bundle (certifi.where() in client.py). After the eMudhra intermediate CA key compromise, Mozilla removed the emSign ECC Root CA - G3 that signed those intermediates, and certifi followed:

certifi emSign roots in bundle
2026.7.22 C1, C3, G1, G3
2026.10.18 none (over-removed)
2026.10.19 C1, C3, G1 (G3 stays out)

This raises the floor from certifi>=2024.7.4 to certifi>=2026.10.19 so a resolver cannot keep an older bundle that still trusts G3. Verified by diffing the three wheels from PyPI. Nothing else changes; the code already reads the bundle through certifi.

🤖 Generated with Claude Code

The SDK verifies gRPC and HTTPS peers against the certifi bundle.
certifi 2026.10.19 follows Mozilla in dropping the emSign ECC Root CA - G3,
the root behind the compromised eMudhra intermediate CAs, so older bundles
must not be resolvable.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
/opt/hostedtoolcache/Python/3.10.22/x64/lib/python3.10/site-packages/netboxlabs/diode/sdk
   _skip_verify_tunnel.py2361295%92, 95, 116–118, 160, 212, 219, 265–267, 326
   chunking.py33197%112
   client.py5974193%195–196, 215–216, 235–237, 240–243, 333, 573, 641, 646, 650, 738–740, 769–771, 801, 833, 855, 857, 931, 962, 970, 1032–1033, 1042, 1075, 1102, 1107–1108, 1137, 1142–1145
   exceptions.py44393%69, 82–83
TOTAL9255794% 

Tests Skipped Failures Errors Time
257 0 💤 0 ❌ 0 🔥 6.295s ⏱️

@nbl-ai-review

nbl-ai-review Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

AI Code Review — risk tier: Trivial · dimensions run: none

Advisory only. A human owns the merge decision.

Summary — Dependency-only version bump raising the certifi floor to 2026.10.19 to drop the compromised emSign ECC Root CA - G3 trust path, exactly as described. No code changes; net positive.

🤖 AI Code Review · run · prompts: code-review/v1 · models: claude-sonnet-5/medium · context: description · 1 comment(s) · 0 prior AI review(s) · usage: $0.43 · 683k in (92% cached) · 1.6k out

@mfiedorowicz
mfiedorowicz merged commit 44ff22f into develop Oct 21, 2026
8 checks passed
@mfiedorowicz
mfiedorowicz deleted the chore/certifi-2026.10.19 branch October 21, 2026 16:57
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.14.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants