Repository navigation
Document the deployed DAO header index limit - #456
Merged
Merged
Conversation
janx
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
RFC 0023 specifies the phase-2 witness field that names a deposit header's index in
header_depsas a 64-bit unsigned little-endian integer, but it does not state the deployed script's effective range.Molecule declares the segment pointer as
uint8_t *:The deployed DAO script requires an eight-byte field but assigns its dereferenced pointer directly to the index:
Dereferencing a
uint8_t *reads one byte. Index 256 is encoded as0x0001000000000000, but the script reads its first byte as index 0. Whenheader_deps[0]is not the intended deposit header, the script loads the wrong header and validation fails.Minimal Proof
Keep up the Great Work,
Phroi %97