Conversation
kapi-version defaults to 1.2.0 in up.yml and gate.yml. The rc14 default reads no source-only recipe and has no --diff-range. gate.yml takes fetch-depth and passes it to actions/checkout. A diff-scoped check reads the commits it compares, and in the depth-1 checkout it had, kapi check --diff-range fails with "HEAD~1 names no commit" on any kapi version. The comments and README name the current gates and the committed unit state under .kapi/state/. test.yml calls both workflows from the checkout on a source-only fixture with kapi 1.2.0-rc32. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRid8i4qnuNfE7Lio73Uu4
Contributor
Author
|
Evidence from real runs. This branch: Test run 34952398751 passed all five jobs:
All of them use kapi Must fail,
The first job fails on the old default. The second fails on the missing history, which the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after kapi 1.2.0 is published. The new default names a release that does not exist until then.
Summary
kapi-versiondefaults to1.2.0inup.ymlandgate.yml(was1.2.0-rc14). The input description says it also takeslatest, which setup-kapi resolves to the newest stable release.gate.ymltakesfetch-depth(default1) and passes it toactions/checkout. A diff-scoped check reads the commits it compares. In the depth-1 checkoutgate.ymlhad,kapi check --diff-rangefails with"HEAD~1" names no commit, so no caller could run one through this workflow on any kapi version. The README shows thefetch-depth: 0form.gate.ymlcomments and the README name the current gates (voice, terminology, rule-based checks) and the unit statekapi commitwrites under.kapi/state/. The retired.kapi-state.jsonis gone from both.test.ymlcalls both reusable workflows from this checkout on a source-only fixture with kapi1.2.0-rc32. It runscheck --ship, a--diff-rangecheck over the commit that last changed the fixture, andkapi up, and a verify job checks each output. The fixture needs no provider key and no server, and it converges with no changes, so nothing is delivered.Evidence
Local, rc32 against rc14 on the same source-only project:
kapi up --json: exit 0,"converged":true.check --ship: PASS.check --diff-range HEAD~1..HEAD -p test/fixture/kapi.yaml, run from the repository root: exit 0, the changed file checked.kapi up:no target languages configured.check --diff-range:unknown flag: --diff-range.--depth 1clone: exit 128,"HEAD~1" names no commit.The must-fail runs on
main'sgate.ymland the green run of this branch are linked in a comment below.Proposed tag
v1.2.0. Every@v1caller that does not pinkapi-versiongets a different CLI, including akapi checkthat no longer passes when it checked nothing. The PR also adds an input, which is more than a fix.Notes
up.yml,gate.ymlandtest.ymlpinactions/checkout@v6; v7 is current.🤖 Generated with Claude Code
https://claude.ai/code/session_01VRid8i4qnuNfE7Lio73Uu4