Repository navigation
fix: Improve regex to extract unstructured fields - #601
Merged
Merged
Conversation
Contributor
|
Side note: IBAN can contain alphanumeric (uppercase) characters after the checksum, and in many countries they do. |
Contributor
Author
Thank you for the info. I checked some examples and it's more complicated then I thought. Anyway: I left the IBAN regex untouched so we should be fine :) |
nemiah
pushed a commit
that referenced
this pull request
Nov 2, 2026
The baseline of #603 was generated before #594, #598 and #601 were merged, so master reports 19 errors. They are fixed in the code instead of being added to the baseline: - Return types for the new test methods and HKWPDv6::setPaginationToken(). - Array value types for GetSEPAAccounts::__serialize()/__unserialize() and the CAMT data provider. - GetSEPAAccountsTest builds the UPD from HIUPDv6 segments, as UPD::$hiupd expects. - HIUPDTest converts its examples in a typed helper (self:: instead of static::), which also clears the six baselined parse() errors. - Drop the two CAMT baseline entries that #601 made obsolete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will improve the extraction of unstructured fields out of
Ustrd.I added tests by using reflections to test the private method. I noticed that the IBAN regex seems weird to me because letters are explicitly allowed after the first characters. For me that doesn't sound right, but maybe there is a reason and I didn't touch it.
The new regex will read now all characters until a new tag/field begins. This started to be an issue after reading now all tags in #583.
We should fix this issue before releasing a new version @nemiah