Repository navigation
Support HKWPD/HIWPD/HIWPDS version 6 for the depot statement - #598
Merged
Merged
Conversation
DKB announces HIWPDS only in version 6, so GetDepotAufstellung failed with 'The server does not support any HIWPDS versions implemented in this library'. Also declares the pagination token for the new request segment.
nemiah
pushed a commit
that referenced
this pull request
Nov 2, 2026
The baseline of #603 was generated before #594, #598 and #601 were merged, so master reports 19 errors. They are fixed in the code instead of being added to the baseline: - Return types for the new test methods and HKWPDv6::setPaginationToken(). - Array value types for GetSEPAAccounts::__serialize()/__unserialize() and the CAMT data provider. - GetSEPAAccountsTest builds the UPD from HIUPDv6 segments, as UPD::$hiupd expects. - HIUPDTest converts its examples in a typed helper (self:: instead of static::), which also clears the six baselined parse() errors. - Drop the two CAMT baseline entries that #601 made obsolete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetDepotAufstellung(HKWPD) only knew version 5. DKB announces the parameter segment only in version 6 (HIWPDS:60:6:3+1+1+0+N:N:N), so requesting the depot statement failed witheven though the depot is listed in the UPD with
HKWPD:1as an allowed business transaction.Changes
HKWPDv6,HIWPDv6,HIWPDSv6. Compared to version 5, the parameter segment has the Sicherheitsklasse again (so it extendsBaseGeschaeftsvorfallparameterinstead of theOldvariant). The request declaresaufsetzpunkt, whichHKWPDv5sets as a dynamic property.GetDepotAufstellungbuildsHKWPDv6for version 6 and collectsHIWPDv5as well asHIWPDv6responses.HKWPDTest(parameters as sent by DKB, request serialization incl. pagination token).Testing
Full PHPUnit suite passes. I also ran a real depot statement against DKB and a second bank with this change; both returned the holdings.
This is (partly) generated code and I as human vouch for it's correctness.
I am using this code in my own repo. If something breaks, i'll fix it. Greets, Felix