Repository navigation
fix(remote): pass custom esbuild plugins through and export runRemoteBuilder - #197
Merged
Merged
Conversation
Aukevanoost
force-pushed
the
fix/remote-plugins-export
branch
from
October 28, 2026 13:10
21dea3c to
97987d9
Compare
Aukevanoost
force-pushed
the
fix/remote-plugins-export
branch
from
October 28, 2026 13:18
97987d9 to
7929d8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #188 (points 1 and 2). #188's point 4 was already fixed on main for #166 (d3da91e, 939a54e) and needs no change here.
runRemoteBuildernow passespluginsto the adapter, the same waybuilddoes (src/builders/build/builder.ts). Before this, a remote dropped every custom plugin it would build with underbuild. Both consumers, the exposes/mappings bundle and the shared externals, already readbuilderOptions.plugins.NfRemoteInternalOptions.pluginsis now optional, becausecreateBuildernever supplies it.runRemoteBuilderis exported from@angular-architects/native-federation/internal. A custom builder can then wrapremoteto add plugins, as it already can forbuild. Importing/internalstill runs build's env setup before remote's. The env vars it sets are the same ones remote's own setup would set, so remote's replay of them logs nothing.The remote builder is experimental, so the exported signature carries no SemVer promise.
Testing
pnpm typecheck,pnpm test(457 passing) andpnpm lintpass.build's, andshared-bundle-settings.specalready covers that plugins get used.