Skip to content

fix(remote): pass custom esbuild plugins through and export runRemoteBuilder - #197

Merged
Aukevanoost merged 1 commit into
mainfrom
fix/remote-plugins-export
Oct 28, 2026
Merged

Aukevanoost merged 1 commit into
mainfrom
fix/remote-plugins-export

Conversation

@Aukevanoost

@Aukevanoost Aukevanoost commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Part of #188 (points 1 and 2). #188's point 4 was already fixed on main for #166 (d3da91e, 939a54e) and needs no change here.

  • Plugins reach esbuild. runRemoteBuilder now passes plugins to the adapter, the same way build does (src/builders/build/builder.ts). Before this, a remote dropped every custom plugin it would build with under build. Both consumers, the exposes/mappings bundle and the shared externals, already read builderOptions.plugins. NfRemoteInternalOptions.plugins is now optional, because createBuilder never supplies it.
  • runRemoteBuilder is exported from @angular-architects/native-federation/internal. A custom builder can then wrap remote to add plugins, as it already can for build. Importing /internal still runs build's env setup before remote's. The env vars it sets are the same ones remote's own setup would set, so remote's replay of them logs nothing.

The remote builder is experimental, so the exported signature carries no SemVer promise.

Testing

  • pnpm typecheck, pnpm test (457 passing) and pnpm lint pass.
  • No new spec. The change is a one-line passthrough, like build's, and shared-bundle-settings.spec already covers that plugins get used.

@Aukevanoost
Aukevanoost force-pushed the fix/remote-plugins-export branch from 97987d9 to 7929d8e Compare October 28, 2026 13:18
@Aukevanoost
Aukevanoost merged commit f1f7f09 into main Oct 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant