fix: validate complete output format names - #128
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format()currently accepts unsupported values such asjsonn,not-json, andiso19116becausere.searchfinds a valid substring. These values then become invalid endpoint extensions instead of raising the documentedValueErrorlocally.Match the entire format name and allow multi-digit UMM version components, preserving valid values such as
umm_json_v1_18. Fix missing commas in four existing valid-format fixtures, which had silently concatenated two UMM version strings.Validation: all 152 tests pass. Twenty invalid-format cases across five query types fail before the fix; three cases verify valid UMM versions.
git diff --checkpasses. This branch is based directly ondevelopand does not include the separate UMM result-parsing change.