Return individual records for UMM JSON query formats - #127
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #94.
Return entries from the
itemsarray forumm_jsonand versionedumm_json_v*responses, including each record'smetaandummfields. This coversresults()and the olderget()APIs, including tool, service, and variable queries. XML and other text formats continue to return whole pages.This intentionally changes UMM JSON callers from page strings to record dictionaries; the README and iterator documentation describe the new behavior. Existing recorded-response tests now consume those records directly.
Validation: all 146 tests pass (
python -m pytest tests -q -p no:cacheprovider). Sixteen parameterized cases cover two UMM formats, four query types, and both retrieval methods; all failed before the change. A separate test checks that XML remains unparsed.git diff --checkpasses.