fix: treat zero cloud cover as a supplied bound - #126
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GranuleQuery().cloud_cover(0, 0)currently raises instead of creating a filter for cloud-free granules. The same truthiness checks also skip range/type validation when either bound is zero.Distinguish omitted bounds from numeric zero. Preserve empty-string open bounds and validate pairs that contain zero. Regression coverage includes exact zero, open bounds ending/starting at zero, reversed bounds, and invalid values paired with zero.
Validation: full suite passes (133 tests and 7 subtests). Seven regression cases fail before the fix.
git diff --checkpasses.