Disallow service accounts from team deletion flow - #532
Merged
Merged
Conversation
Block service accounts from requesting or confirming team deletion, even when they have the Team owner role. Add authz coverage and integration tests to verify rejected attempts do not create keys, confirm deletions, or write activity log entries. Update deletion docs to clarify the human-user requirement.
thokra-nav
requested
a balanced review from Copilot
and removed request for
a team
September 30, 2026 13:34
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The authorization change is focused and covered by unit and integration tests for both deletion operations.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents service accounts from participating in the team deletion flow.
Changes:
- Rejects service accounts in team deletion authorization.
- Adds authorization and integration coverage for rejected attempts and side effects.
- Documents the human-user requirement.
| File | Description |
|---|---|
internal/auth/authz/queries.go |
Rejects service accounts during deletion authorization. |
internal/auth/authz/authz_test.go |
Tests service-account rejection. |
integration_tests/request_team_deletion.lua |
Verifies rejected requests have no side effects. |
integration_tests/confirm_team_deletion.lua |
Verifies rejected confirmations leave deletion pending. |
docs/deleting_teams.md |
Documents the service-account restriction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block service accounts from requesting or confirming team deletion, even when they have the Team owner role. Add authz coverage and integration tests to verify rejected attempts do not create keys, confirm deletions, or write activity log entries. Update deletion docs to clarify the human-user requirement.