Polish Task Workspace UX: XOR link select, id chip, Portal tokens - #38
Merged
Merged
Conversation
- Label section exactly Workspace: for teacher and student - Empty state uses short Enable/Link buttons; link mode swaps in Add Class-style select - Dedupe linkable workspaces by workspace_id from board tasks via ViewTask parent prop - Active header is a compact workspace id chip linked to Drive folder URL when available - XOR chrome: empty actions, link picker, or dropzone/files/footer (Destroy only in footer) - Connect Drive uses quiet button_pointer_text; reuse Portal action tokens throughout Co-authored-by: Sander Vonk <sandervonk@users.noreply.github.com>
sandervonk
marked this pull request as ready for review
September 8, 2026 19:21
sandervonk
added a commit
to cmu-tt/cmu-tt.github.io
that referenced
this pull request
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
High-quality UX + styling pass for Task Workspace on top of #37:
styled_inputselect (no raw workspace ID text field)workspace_id, deduped by id, labeled by task name (class · taskwhen available) via newlinkableWorkspacesprop fromViewTaskback_action/click_escapeand confirms withcontinue_actiondrive_folder_url/drive_folder_idis present)button_pointer_text)Files
src/components/Portal/TaskWorkspace.vue— template/state/styling overhaulsrc/common/workspace.ts—LinkableWorkspace,linkableWorkspaceLabel,workspaceDriveFolderUrl, drive folder fieldssrc/views/Portal/ViewTask.vue—linkableWorkspacescomputed + prop wiringTest plan
npm run lintnpm run build