Task Workspaces UI + migrate done/notes to API - #36
Merged
Merged
Conversation
- Route set_finished and set_note through PATCH /api/v1/me/tasks (done/undo shims, 404 shims) - Hydrate task_states from GET /api/v1/me/board (completed, note, workspace_id) - Add TaskWorkspace panel in ViewTask (enable/link/destroy, drop zone, Drive connect) - Teacher workspace uses class teacher-workspace routes when caller can manage class - Calendar and study views read completion via is_task_completed from API state Co-authored-by: Sander Vonk <sandervonk@users.noreply.github.com>
- Drop .ts extension from meTaskState paths import - Use finished_tasks in upcoming_todo getter (avoid action call from getter) - Narrow MeTaskState lookup in note_for before reading .note Co-authored-by: Sander Vonk <sandervonk@users.noreply.github.com>
sandervonk
marked this pull request as ready for review
September 8, 2026 17:47
sandervonk
added a commit
to cmu-tt/cmu-tt.github.io
that referenced
this pull request
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vue Portal changes for task workspaces and migrating personal done / notes off client Firestore writes.
API migration (no more Firestore
finished[]/noteswrites for these actions)set_finished→PATCH /api/v1/me/tasks/:taskPathwith{ completed }(falls back toPOST …/done/…/undo, then local stub on 404)set_note→ same route with{ note }completed,note,workspace_id,completed_at,note_updated_atfromGET /api/v1/me/boardtask_statesmap +is_task_completed()— calendar/study/upcoming read API state first, legacyfinished[]read-only fallbackWorkspace UI (View Task)
TaskWorkspace.vuein task detail: Enable workspace, Link existing (shareableworkspace_idacross project steps), Destroy (confirm modal)var(--color-overlay-input), drag-over translucentvar(--color-action)with centered action-colored label, Add file + file listPOST /api/v1/oauth/drive/start(best-effort; warns when route not live)/api/v1/me/classes/:classId/teacher-workspaceroutesServer contract notes (mvtt-server sibling)
Assumed routes (client stubs when 404 mid-dev):
PATCH /api/v1/me/tasks/:taskPath,POST …/done,POST …/undoGET/POST/DELETE /api/v1/me/tasks/:taskPath/workspace,POST …/linkGET/POST/DELETE /api/v1/me/classes/:classId/teacher-workspace,POST …/linkGET /api/v1/workspaces/:id,POST …/files,DELETE …/files/:fileIdPOST /api/v1/oauth/drive/start→{ url }Screenshots (drop zone states)
Workspace drop zone — idle
Workspace drop zone — drag over
Workspace drop zone — with files
Tests
npm run test:me-tasks— task state map helpersnpm run test:me-board— unchanged, still passesFiles
src/common/meTasks.ts,meTaskState.ts,workspace.ts— API clients + 404 stubssrc/components/Portal/TaskWorkspace.vue— workspace panelsrc/store/index.ts— API-backedset_finished/set_note, board ingestsrc/views/Portal/ViewTask.vue— embed workspace sectionCalendarBlock.vue,StudyBlock.vue—is_task_completedTo show artifacts inline, enable in settings.