Skip to content

Fix lint, build with Node.js 24 and pin the workflow actions - #3

Merged
DRovara merged 5 commits into
mainfrom
chore/lint-node-pin
Oct 29, 2026
Merged

DRovara merged 5 commits into
mainfrom
chore/lint-node-pin

Conversation

@DRovara

@DRovara DRovara commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Follow-ups from #2.

  • Lint: npm run lint passes now, and the editor workflow runs it on every pull request.
    • Most fixes are formatting from eslint --fix.
    • Removes symbolic-simulator.js, an unused prototype that nothing imports and whose gates refer to undefined variables.
    • One behaviour fix: the gate count block compared with NaN and so never rejected a count that isn't a number; it does now.
    • The extension tests give the same result as before (363 passing).
  • Node.js 24: .nvmrc, engines and the docs move from Node.js 20, which is end of life, to 24.
  • Actions: every action is pinned to a commit SHA, with the version in a comment, and updated to its current release. The new versions run on Node.js 24, which removes the deprecation warning in the workflow logs.

🤖 Generated with Claude Code

DRovara and others added 5 commits October 28, 2026 23:49
Nothing imports it, and its gates refer to variables that don't exist. The editor uses statevector-simulator.js.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Most fixes are formatting from eslint --fix. Besides that, the gate count block now rejects a count that is not a number; the check compared with NaN and was always false.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Node.js 20 reached its end of life in April 2026.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pinning keeps a moved tag from changing what runs with write access to gh-pages. The new versions run on Node.js 24 instead of the deprecated Node.js 20.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.2
Preview removed because the pull request was closed.
2026-10-29 09:24 UTC

@DRovara
DRovara merged commit 5a1465c into main Oct 29, 2026
8 checks passed
@DRovara
DRovara deleted the chore/lint-node-pin branch October 29, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant