Repository navigation
Fix loading empty no-cache client scripts - #5499
Merged
FileEX merged 1 commit intoOct 7, 2026
Merged
Conversation
Collaborator
|
Tested and works. |
FileEX
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5498
Description
This addresses a regression introduced during recent packet validation hardening (#5037). While adding bounds checking against oversized script chunks, zero-length scripts were inadvertently treated as invalid packet data and rejected, aborting the packet processing early and preventing the resource from loading the rest of its client scripts.
This change allows empty (0-byte) scripts to pass through and load normally as valid blank chunks, while keeping the 50 MB upper size limit and packet validation intact.
Test plan
Tested using the reproduction resource provided in #5498 (
hud.zipwith a blankcache="false"script)