Repository navigation
Fix CEF browser destruction on the wrong thread - #5447
Open
MoriskaSosiska wants to merge 8 commits into
Open
MoriskaSosiska wants to merge 8 commits into
MoriskaSosiska wants to merge 8 commits into
Conversation
Member
|
Please, fix clang format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release web browser render items on the render thread before closing CEF asynchronously.
This prevents CEF UI-thread destruction from releasing DX resources, which could cause hangs during frequent browser creation/destruction cycles.
Also synchronize
GetViewRectwith render-item detachment, free retained frame buffers earlier, and remove the redundantabout:blanknavigation before a forced browser close.