Repository navigation
Conversation
removeElementData can now be called on the client which actually deletes (rather than just sets to nil or false) an element data. It also sends a new packet type to the server and syncs it with clients.
Collaborator
Author
|
Tested everything with 2 PCs, fixed that client variable wasn't being sent to onElementDataChange when a client used removeElementData. |
FileEX
requested changes
Apr 8, 2026
Collaborator
Author
|
I've made the requested changes and re-tested it. |
FileEX
reviewed
Apr 9, 2026
FileEX
previously approved these changes
Apr 9, 2026
tederis
requested changes
Apr 9, 2026
Collaborator
Author
|
Requested changes have been added and re-tested. |
tederis
previously approved these changes
Apr 9, 2026
FileEX
previously approved these changes
Apr 9, 2026
qaisjp
reviewed
May 11, 2026
qaisjp
reviewed
May 11, 2026
qaisjp
requested changes
May 11, 2026
qaisjp
left a comment
qaisjp
left a comment
Member
There was a problem hiding this comment.
Left some feedback about how we can preserve ordering + reuse the same packet, instead of using a new packet.
Member
|
Sorry! I know it can be frustrating to go through multiple rounds of review :( |
Collaborator
Author
|
Made it so the new RPC isn't needed, checked for compliance with coding guidelines, and re-tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #594
removeElementData can now be called on the client which actually deletes (rather than just sets to nil or false) an element data. It also sends a new packet type to the server and syncs it with clients.
Motivation
To actually delete element data so that nil or false isn't being unnecessarily synced to future clients.
Test plan
Although I didn't test with 2 PCs I used it on an object then reconnected to verify that new clients are no longer being synced a removed element data.
Edit: tested with 2 PCs and the remote players have the element data removed correctly.