Skip to content

gui: set theme to ModernStyle to prevent wizard defaulting to Aero on windows (bug 1987300) - #2207

Merged
olliehcrook merged 2 commits into
mozilla:mainfrom
olliehcrook:bug-1987300
Oct 21, 2026
Merged

olliehcrook merged 2 commits into
mozilla:mainfrom
olliehcrook:bug-1987300

Conversation

@olliehcrook

Copy link
Copy Markdown
Collaborator

No description provided.

@olliehcrook
olliehcrook requested a review from zzzeid October 21, 2026 08:33
@olliehcrook
olliehcrook marked this pull request as ready for review October 21, 2026 08:46
@olliehcrook

olliehcrook commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

Added some extra details about fix (inc screenshot) on the bug.

Comment thread gui/mozregui/ui/intro.ui
</property>
<property name="styleSheet">
<string notr="true">font-size: 10px;</string>
<string notr="true">color: gray; font-size: 10px;</string>

@olliehcrook olliehcrook Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I thought that grey in darkmode was too dark, but I looked again and think its fine, and is best to not affect lightmode with this. Removed the change to intro.ui.

Comparisons

In both, first is after removing color attribute and after is adding it back.

Another option could be to conditiionally style it, but I think dark mode is ok with grey. Initially I had my screen brightness low when I made this change so the text was hard to read.

Lightmode comparison

Image Image

Dark mode comparison

Image Image

@olliehcrook
olliehcrook merged commit df7a333 into mozilla:main Oct 21, 2026
17 checks passed
@olliehcrook
olliehcrook deleted the bug-1987300 branch October 21, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants