Repository navigation
Conversation
mversic
force-pushed
the
parse-assoc-types
branch
from
December 7, 2023 08:24
c15a902 to
cda3c70
Compare
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
orangeng
changed the title
orangeng
changed the title
orangeng
force-pushed
the
parse-assoc-types
branch
from
December 7, 2023 09:19
cda3c70 to
712ca52
Compare
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
mversic
reviewed
Dec 7, 2023
orangeng
force-pushed
the
parse-assoc-types
branch
2 times, most recently
from
December 11, 2023 07:27
2cd1735 to
a76a4e8
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
February 15, 2024 18:04
a76a4e8 to
beb281c
Compare
Contributor
mversic
force-pushed
the
parse-assoc-types
branch
from
March 9, 2024 08:50
beb281c to
3ff88a9
Compare
mversic
force-pushed
the
parse-assoc-types
branch
4 times, most recently
from
April 23, 2024 11:49
fa24f93 to
2895b55
Compare
Contributor
|
@emilio is there something blocking the merge of this feature? |
mversic
force-pushed
the
parse-assoc-types
branch
2 times, most recently
from
May 17, 2024 20:08
c7f64b2 to
5258104
Compare
Contributor
|
@emilio do you think we can get this PR merged soon? |
mversic
force-pushed
the
parse-assoc-types
branch
2 times, most recently
from
June 4, 2024 11:56
4cd9216 to
862232e
Compare
|
We're currently using this in prod. Would love to get this merged in! Without this PR out entire cbindgen flow wouldn't work. Thanks @orangeng for your awesome contribution! |
mversic
force-pushed
the
parse-assoc-types
branch
from
August 22, 2024 17:51
862232e to
60fabe5
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
November 1, 2024 15:46
60fabe5 to
5edf653
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
November 14, 2024 16:22
5edf653 to
bbf7444
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
January 9, 2025 19:02
bbf7444 to
3be78eb
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
February 24, 2025 19:27
2eb6351 to
52b95f1
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
May 26, 2025 16:48
52b95f1 to
c7779fa
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
August 3, 2025 11:39
c7779fa to
b63db68
Compare
mversic
force-pushed
the
parse-assoc-types
branch
from
October 9, 2025 19:28
b63db68 to
33cd906
Compare
|
Any update on getting this merged? |
mversic
force-pushed
the
parse-assoc-types
branch
from
October 1, 2026 14:39
33cd906 to
ebc070f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the parsing stage, the functionality of the syn::Impl parsing is extended to keep track of associated type implementations in trait Impls.
This info is kept in a hash-map, where the key is a combination of (self type, trait name, associated type name) and the value is the concrete type itself.
In the library/transformation stage, this populated hashmap is then referenced to resolve associated types found.
Closes #106