Skip to content

Bug 2081090 - #2793

Merged
dklawren merged 1 commit into
mozilla:masterfrom
dklawren:2081090
Oct 21, 2026
Merged

dklawren merged 1 commit into
mozilla:masterfrom
dklawren:2081090

Conversation

@dklawren

Copy link
Copy Markdown
Collaborator

Review carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2081090

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped normalization has focused regression coverage and no identified blocking issues.

No open issues 🎉

What changed in this PR

This PR addresses Bug 2081090 by normalizing content-type extensions in get_format, keeping template selection, content-type lookup, and callers’ extension checks consistent.

Changes:

  • Lowercase ctype before constructing the template filename.
  • Add regression tests for mixed-case inputs, the default HTML extension, and the unknown content-type fallback.
File Description
t/​template-get-format-case.t Tests case normalization, default behavior, and fallback content type.
Bugzilla/​Template.pm Normalizes ctype to lowercase before template resolution.

Review effort: Balanced

@dklawren
dklawren merged commit ac3ee7d into mozilla:master Oct 21, 2026
8 checks passed
@dklawren
dklawren deleted the 2081090 branch October 21, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants