Repository navigation
Bug 2081090 - #2793
Merged
Merged
Bug 2081090#2793
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped normalization has focused regression coverage and no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR addresses Bug 2081090 by normalizing content-type extensions in get_format, keeping template selection, content-type lookup, and callers’ extension checks consistent.
Changes:
- Lowercase
ctypebefore constructing the template filename. - Add regression tests for mixed-case inputs, the default HTML extension, and the unknown content-type fallback.
| File | Description |
|---|---|
t/template-get-format-case.t |
Tests case normalization, default behavior, and fallback content type. |
Bugzilla/Template.pm |
Normalizes ctype to lowercase before template resolution. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2081090