Repository navigation
Bug 2080901 - [BMO-ETL] When any table fails to export, the entire snapshot should be rolled back to avoid incorrect results in charts/dashboards - #2784
Merged
Conversation
…apshot should be rolled back to avoid incorrect results in charts/dashboards
There was a problem hiding this comment.
🟡 Changes recommended
Locking and remote query lifecycle issues can still allow duplicate snapshots or interrupt valid exports.
0 open findings
What changed in this PR
This PR aims to prevent partial BMO-ETL snapshots from affecting charts and dashboards by staging exports before transactional publication.
Changes:
- Adds staging tables, transactional publication, and cleanup.
- Introduces lock heartbeats, stale-lock recovery, and query polling.
- Expands tests for retries, cleanup, locking, and invalid dates.
| File | Description |
|---|---|
| extensions/BMO/t/bmo/bmo_etl.t | Adds export lifecycle and validation tests. |
| extensions/BMO/Extension.pm | Adds the lock heartbeat column and migration. |
| extensions/BMO/bin/export_bmo_etl.pl | Implements staged publication and export lifecycle handling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cgsheeh
approved these changes
Oct 15, 2026
Collaborator
Author
|
This ran without issue on bugzilla-dev so ready for testing on production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.