Repository navigation
Conversation
This was referenced Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static flash currently accepts only SSI, which prevents simulator flash reuse from performing the short Newton attempt described by Rasmussen et al. (2006) and Belkadi et al. (2011, SPE 142132, Section 2.1).
Add a safeguarded phase-amount Gibbs minimization for
NewtonFlash. It shares the static equilibrium residual/Jacobian builder with the two-phase implicit derivatives and transforms that Jacobian to the scaled Gibbs Hessian. Restore material balance before the first EOS evaluation and report nonconvergence for an indefinite Hessian, nonpositive phase amounts, increasing Gibbs energy, or the iteration limit. The caller can then fall back to SSI. Static factorization supports up to 24 components.Preserve Float32 types in cubic-root evaluation so this path also compiles on GPUs. Bump MultiComponentFlash to 2.1.0 so the dependent simulator change can require the new capability.
Validation on Julia 1.13.1:
This is a prerequisite for a separate JutulDarcy reuse fix. Stability changes and the H2 correlation are outside this PR.
Related drafts: JutulDarcy reuse #353, stability #41.