[aviggiano]

Summary

The controller integration fixture added by #1315 still calls preflightJsonValidator as a synchronous three-argument function. #1318 made it asynchronous and requires an AbortSignal. The stale fixture leaves a rejected promise unobserved, so Smithers records TASK_ABORTED and cancels the run before the test can check its intended TOOL_UNAVAILABLE failure.

Await the current validator preflight, pass a signal, use the real runProcessGroup, and wrap its failure through the same named preparation step used by the generated workflow. This keeps the existing assertions for one failed attempt, no retry, and the exact TOOL_UNAVAILABLE code.

This fixes the single support-lane failure in #1329's exact-head run 40396550104. The same test failed on pre-#1329 unstable at b33cb2d, both with and without the scratch runner.

Validation

• Runtime test TypeScript compilation passed.
• node scripts/run-tests.mjs smithers-controller-engine.integration: 3/3 passed, including the formerly failing case.
• Strict CI diff lint against ee990b2, Prettier, and git diff --check passed.

Confidence Score: 5/5

This fixture update appears safe to merge.

Summary

Updates the controller fixture to await preflightJsonValidator, pass an AbortSignal, and use runProcessGroup.

• The controller fixture records validator launch failures under their preparation step.

_{Reviews (1) · Last reviewed commit: "test(runtime): await validator preflight..." · Reviewed by Greptile}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T20:53:29.970662Z	419a824	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.