Repository navigation
test(runtime): reclaim direct node:test fixture roots after each case - #1333
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
aviggiano
force-pushed
the
fup-1322-supporting-fixture-cleanup
branch
from
October 26, 2026 20:55
92d5d23 to
3e988b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1329: reclaim fixture roots created by supporting tests that call
node:testdirectly after each case. Keep each root available through its test's own teardown hooks, including nested and failed cases. If a teardown hook throws and skips the late cleanup hook, drain that test's pending roots before the next case or the parent's teardown.Scope roots created inside a direct test's async teardown to that test. Preserve intentional process-lifetime fixtures: the shared lifecycle inspection project and its sibling fake runner, module-level provider homes, and the Smithers poison binary. Bun continues to use the scoped runtime wrapper because its module cache does not register these direct hooks across multiple files.
Fixes #1322.
Validation
pnpm install --frozen-lockfilepnpm --filter @ultrafuzz/runtime... buildtsc -p packages/runtime/tsconfig.test.json --pretty falseESLINT_PLUGIN_DIFF_COMMIT=91730f76a2c06bdf0b8f2ff1a659e72c5b032d2c pnpm -w lint:strict:cigit diff --check

Confidence Score: 5/5
The PR appears safe to merge; no new actionable issues remain.Summary
This PR removes temporary fixtures after direct Node tests while keeping them available through each test’s teardown.
Both earlier, unnumbered findings are addressed by the pending-scope drain and teardown-specific scope. No new actionable issues were found.
Reviews (4) · Last reviewed commit: "test(runtime): retain shared fixtures an..." · Reviewed by Greptile