Repository navigation
fix(runtime): qualify failed and stopped Codex command receipts - #1330
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bebbebd1b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function suppliesHookConfiguration(args: string[]): boolean { | ||
| return ( | ||
| args.some((argument) => /^(?:--config=|-c)?\s*(?:hooks(?:[.=]|\s*=)|features\.hooks\s*=)/u.test(argument)) || | ||
| args.some((argument) => /^(?:(?:--config|-c)=)?\s*(?:hooks(?:[.=]|\s*=)|features\.hooks\s*=)/u.test(argument)) || |
There was a problem hiding this comment.
When a caller uses an attached short override such as -chooks.PostToolUse=[] or -chooks={}, this regex no longer recognizes it, so the adapter injects its own settings and reports the command guard enabled even though the later caller override can disable the completion hook or all hooks; completed commands can then remain active and identical commands be incorrectly denied. Codex 0.146.0 declares this option as a value-taking clap short -c (Codex source), and clap documents attached values such as -oval as equivalent to -o val (clap documentation), so retain support for the previously matched -cVALUE form while adding -c=VALUE.
Useful? React with 👍 / 👎.
bebbebd to
c240dc5
Compare
c240dc5 to
1b02b59
Compare
Summary
Follow-up to #1319; adds the real Codex CLI completion cases requested in its review and continues the qualification work tracked by #1317.
PostToolUsecompletion receipt and allow a new identical command to run exactly once.-c=features.hooks=falseand-c=hooks.PostToolUse=[]as caller-provided hook configuration, so the adapter reports the command guard inactive instead of claiming it is enabled.The real CLI tests use a local server and require no provider credentials. They run when
ULTRAFUZZ_TEST_CODEXpoints to the pinned@openai/codex@0.146.0binary.Validation
pnpm --filter @ultrafuzz/cli... buildpnpm exec tsc -p packages/runtime/tsconfig.test.jsonpnpm exec prettier --check packages/runtime/src/command-invocations.ts packages/runtime/test/command-invocations.test.tspnpm exec eslint packages/runtime/src/command-invocations.ts packages/runtime/test/command-invocations.test.tsgit diff --check
The PR appears safe to merge; no actionable issues were found.Summary
The adapter now recognizes inline
-c=hook settings and reports the command guard inactive instead of injecting its own hooks.-chook settings.Reviews (2) · Last reviewed commit: "test(runtime): cover Codex failure and s..." · Reviewed by Greptile