Skip to content

chore(tests): drop the gas sizing helpers nothing calls - #62

Merged
QEDK merged 1 commit into
forks/monad_ninefrom
tests/drop-unhardcode-gas-remnants
Oct 12, 2026
Merged

QEDK merged 1 commit into
forks/monad_ninefrom
tests/drop-unhardcode-gas-remnants

Conversation

@pdobacz

@pdobacz pdobacz commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Upstream changes to gas accounting has made a bunch of our Monad-specific workaround obsolete. Cleaning up

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the cleanup preserves gas values and fork-specific test coverage.

Summary

Removes unused gas helpers and fixture parameters from execution tests.

  • Self-destruct cases run without an unused gas estimate input.
  • CLZ tests drop an unused gas helper and extra fork inputs.
  • The opcode test passes its gas limit directly to each call.

No actionable issues were found. Tests were not run.

Reviews (1) · Last reviewed commit: "chore(tests): drop the gas sizing helper..." · Reviewed by Greptile

Automatic transaction gas limits made them dead; the files now match upstream.

Co-Authored-By: Claude <claude-fable-5-1>
@pdobacz
pdobacz requested review from QEDK and mijovic as code owners October 12, 2026 14:26

@QEDK QEDK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@QEDK
QEDK merged commit 05ed9e0 into forks/monad_nine Oct 12, 2026
12 checks passed
@QEDK
QEDK deleted the tests/drop-unhardcode-gas-remnants branch October 12, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants