Repository navigation
Use a current Bun runtime for development reloads - #179
Merged
Merged
Conversation
Reject development runtimes older than the packageManager baseline, preserve the checked executable for server children, and remove the TanStack HMR acceptance workaround. Document the upstream QueryClient re-export bug and the separate automatic browser reload limitation. Validated 28 frontend edits on Bun 1.3.14, generated Tailwind CSS, stylesheet updates and fresh-tab loading. Launcher tests, typecheck, repository checks and formatting pass; lint reports existing warnings only.
Keep the version check in the existing server launcher and consolidate its tests. Remove the standalone development guide; retain only the short setup note, with investigation details in the PR. Adapt the existing CLI capture fixture to the executable-preserving child launch. Validated 36 launcher and CLI tests, typecheck, lint, formatting and repository checks. Sandbox DNS and orphan-worker test failures reproduce on unchanged main.
molefrog
reviewed
Oct 29, 2026
| "@types/react-dom": "^19.2.7", | ||
| "@types/react-grid-layout": "^2.1.0", | ||
| "@types/react-resizable": "^3.0.8", | ||
| "bun": "1.3.14", |
Owner
There was a problem hiding this comment.
Maybe it should be?
Suggested change
| "bun": "1.3.14", | |
| "bun": ">1.3.14", |
molefrog
approved these changes
Oct 29, 2026
tonyfresher
changed the title
tonyfresher
force-pushed
the
fix/dev-query-client-hmr
branch
from
October 29, 2026 16:04
ecacf2f to
f0edd0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bun 1.3.10 can lose TanStack Query re-exports after frontend rebuilds, producing
QueryClient is not a constructoruntil the server restarts (report, upstream fix). Development now requires Bun 1.4.4, checks the version before startup, and keeps server children on the launcher's executable. The TanStack-specific HMR plugin is removed.CI and release setup read
packageManager; the explicitbun >=1.4.4development dependency prevents an older transitive Bun from taking over package scripts. The lockfile resolves Bun 1.4.4.Linux CI exposed a separate native-library interaction: a
Bun.secrets.get()probe loads system GLib/GObject even when it fails withlibsecret not available; subsequent Sharp image processing segfaults. This reproduces in a small standalone process, with either import order. Updating Sharp to 0.35.5 did not resolve the full-suite crash. CI and release tests now use the existingMOI_SECRET_BACKEND=filesetting with normalbun test. Per-file isolation and temporary diagnostics have been removed. Production keychain behavior is unchanged.Validation: Linux and Windows CI pass on ecacf2ff. Linux runs all 2,397 tests across 251 files in one process with zero failures; frozen install, lint, formatting, registry validation, repository checks, typecheck, and package inspection also pass. The 25 focused dependency-reload, attachment, and secret-store tests pass locally.
Some dependency edits still trigger automatic full-page reloads; state-preserving Fast Refresh is not guaranteed for every edit.