Repository navigation
Conversation
This was referenced Oct 25, 2026
moetemp
force-pushed
the
moe/brook/review/b1-streams-feature
branch
3 times, most recently
from
October 27, 2026 09:07
8aa8d7f to
4dd874f
Compare
moetemp
changed the base branch from
moe/brook/review/base
to
moe/brook/review/g3-workflow-task
October 27, 2026 09:07
The feature builds the crate's Stream runtime for a backend, on Redis or on the memory Store. The official wheels and the FIPS build turn it on. `StreamCallError` is in every build, so Python can map its errors.
moetemp
force-pushed
the
moe/brook/review/b1-streams-feature
branch
from
October 28, 2026 01:33
4dd874f to
f2244db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds the
streamscargo feature to the bridge, which links the Stream runtime crates and builds a runtime for the Redis and memory backends.temporalio-streamshas the runtime and the memory Store, andtemporalio-streams-redishas the Redis Store.poe build-developand every wheel build.fipsturns it on too.StreamCallErroris in every build, so Python can import it with the feature off.temporalio-streamscomes from the Core submodule.[patch.crates-io]points the Redis crate'stemporalio-commonandtemporalio-streamsat the submodule, so the bridge sees one copy of each type.fipsfeatures forward to the Redis crate, which links the Redis client.86b1ee18onmoetemp/sdk-rust, the Stream crate of feat: add the temporalio-streams crate with the Stream protos temporalio/sdk-rust#1733 and its writers on top of the merged feat(brook): add the dispatching Workflow Task to each Local Activity start temporalio/sdk-rust#1703. Its wire has theStreamRef, aoneofProducer epoch, a strict create with a request id, and a close that writes no Record.Cargo.tomltakestemporalio-streams-redisby git fromtemporal-community/sdk-streamsat6500b21d, and Cargo fetches it with the feature off too. Upstream pins the merged Core commit, takes the Redis crate from crates.io by version, keeps the patch and drops the git source.Why?
The Stream runtime is Rust, so every SDK shares the Store logic and its rules. A Python build links it like the rest of Core.
Open question. With the feature off by default, a source build from the sdist has no Stream runtime, but the wheels have it. Should it be on by default once the crate is on crates.io?
Part of the Streams review series.
Checklist
poe lint,cargo clippyandcargo fmton both feature sets, andpytest tests/bridge.