Repository navigation
fix: keep optional ImageMagick demo import-safe - #232
Merged
Merged
Conversation
Run the legacy demo only on explicit invocation; keep collection free of optional media side effects. Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the optional ImageMagick demo safe to import. Pytest discovers its
imagemagick_test.pyfilename, but importing it previously started TextClip,opened external example media and attempted to export a video. In an ordinary
CPU development environment, collection stopped at ImageMagick executable
unsetbefore the repository tests could run.Put the existing demo, including optional MoviePy imports, behind an explicit
__main__guard. Its rendering body is unchanged. No test exclusion, new skip,dependency upgrade or production clipping/ASR behavior change is introduced.
Validation
-I -Sin an empty workingdirectory. It fails before the fix on the eager MoviePy import, then passes
without optional packages, rendering, output files or stdout/stderr.
rendering is not newly certified; its external media/font/ImageMagick
prerequisites remain outside this import-safety fix.
15 failed, 1 skipped in the isolated source snapshot. All 15 related
demo/Gradio/installation/CLI checks pass. This is not a green full suite.
litellm;one canonical-link test requires Git metadata absent from this verified
source export (
git ls-filesexit128). The existing live Pegasus test skipswithout its API key. Negative results and complete JUnit/logs are retained.
use existing test doubles; no paid service, pretrained model or GPU work.
dependencies. Exact-head and final-main CI/log acceptance are separate gates.
Scope
Three paths only: the optional demo, its import regression, and the CI command.
No full ASR, actual ImageMagick rendering or recognition-to-clipping claim.
No issue is automatically closed, no release is created, and no repository
protection is changed. Inline author review is not an independent approval;
integration uses the normal merge path after actual test and CI verification.