Skip to content

GPS updates: updates_per_second default, speed, guess_offset #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddennedy merged 4 commits into from
Oct 6, 2026
Merged

GPS updates: updates_per_second default, speed, guess_offset #1921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d821531
GPS text: updates_per_second default changed to -1; GPS graphic: add …
dany123 Sep 29, 2026
7b59327
filter.istAtLeastVersion(9) for new defaults
dany123 Sep 29, 2026
f45298d
Merge branch 'mltframework:master' into gps_updates
dany123 Oct 3, 2026
c9e2f07
fix missing filter.
dany123 Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/qml/filters/gpsgraphic/ui.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@ Item {
} else {
gpsFinishParseTimer.stop();
calls = 0;
filter.set('time_offset', filter.get('auto_gps_offset_start'));
setControls();
}
}
Expand Down Expand Up @@ -859,10 +860,10 @@ Item {

value: 1
horizontalAlignment: Qt.AlignRight
Layout.minimumWidth: 80
Layout.minimumWidth: 100
from: 0
to: 10000
decimals: 2
decimals: 3
stepSize: 1
suffix: 'x'
onValueChanged: {
Expand Down
23 changes: 14 additions & 9 deletions src/qml/filters/gpstext/ui.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,10 @@ Shotcut.KeyframableFilter {
filter.set('smoothing_value', 5);
filter.set('videofile_timezone_seconds', 0);
filter.set('speed_multiplier', 1);
filter.set('updates_per_second', 1);
if (filter.isAtLeastVersion(9))
filter.set('updates_per_second', -1);
else
filter.set('updates_per_second', 1);
filter.set('gps_processing_start_time', 'yyyy-MM-dd hh:mm:ss');
} else {
if (filter.get('gps_processing_start_time') == 'yyyy-MM-dd hh:mm:ss' && filter.get('gps_start_text') != '')
Expand Down Expand Up @@ -646,10 +649,10 @@ Shotcut.KeyframableFilter {

value: 1
horizontalAlignment: Qt.AlignRight
Layout.minimumWidth: 80
Layout.minimumWidth: 100
from: 0
to: 1000
decimals: 2
to: 10000
decimals: 3
stepSize: 1
suffix: 'x'
onValueChanged: {
Expand Down Expand Up @@ -903,15 +906,17 @@ Shotcut.KeyframableFilter {
Layout.alignment: Qt.AlignRight

Shotcut.HoverTip {
text: qsTr('Set how many text updates to show per second.\nSet to 0 to only print real points (no interpolation).')
property var string_v0: qsTr('Set how many text updates to show per second.\nSet to 0 to only print real points (no interpolation).')
property var string_v9: qsTr('Set how many text updates to show per second.\nSet to 0 to only print real points (no interpolation).\nSet to -1 to update every frame.')
text: (filter.isAtLeastVersion(9) ? string_v9 : string_v0)
}
}

RowLayout {
TextField {
id: updates_per_second

text: '1'
text: (filter.isAtLeastVersion(9) ? '-1' : '1')
horizontalAlignment: TextInput.AlignRight
implicitWidth: 25
onFocusChanged: {
Expand All @@ -925,7 +930,7 @@ Shotcut.KeyframableFilter {
}

validator: DoubleValidator {
bottom: 0
bottom: (filter.isAtLeastVersion(9) ? -1 : 0)
top: 1000
}
}
Expand All @@ -936,8 +941,8 @@ Shotcut.KeyframableFilter {

Shotcut.UndoButton {
onClicked: {
filter.set('updates_per_second', 1);
updates_per_second.text = '1';
filter.set('updates_per_second', (filter.isAtLeastVersion(9) ? -1 : 1));
updates_per_second.text = (filter.isAtLeastVersion(9) ? '-1' : '1');
}
}
}
Expand Down
Loading