Skip to content

Fix training difference test result handling - #927

Open
mrhimanshu wants to merge 1 commit into
mlcommons:devfrom
mrhimanshu:codex/fix-traindiff-temp-files
Open

mrhimanshu wants to merge 1 commit into
mlcommons:devfrom
mrhimanshu:codex/fix-traindiff-temp-files

Conversation

@mrhimanshu

Copy link
Copy Markdown

Summary

  • isolate JAX and PyTorch result pickles per workload invocation
  • propagate framework subprocess failures before reading result files
  • document full and single-workload commands and runtime requirements
  • add unit coverage for temporary-file cleanup and failure propagation

Fixes #808

Validation

  • uvx ruff==0.12.0 check .
  • uvx ruff==0.12.0 format --check .
  • focused Python 3.11 unit tests: 3 passed

The full training-difference suite was not run locally because it requires eight visible GPUs, both framework stacks, and workload data.

Tooling disclosure: agent assistance was used during implementation and validation.

@mrhimanshu
mrhimanshu requested a review from a team as a code owner October 7, 2026 07:51
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

MLCommons CLA bot:
Thank you very much for your submission; we really appreciate it. Before we can accept your contribution,
we ask that you sign the MLCommons CLA (Apache 2). Please submit your GitHub ID to our onboarding form to initiate
authorization. If you are from a MLCommons member organization, we will request that you be added to the CLA.
If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact
support@mlcommons.org.
0 out of 1 committers have signed the MLCommons CLA.
❌ @mrhimanshu
You can retrigger this bot by commenting recheck in this Pull Request

@mrhimanshu

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant