🐛 fix for mb_str_pad not existing in php 8.1

[ianardee]

Description

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Requires a change to the official Guide documentation.

[Copilot]

🟡 Changes recommended

The updated static-analysis reusable workflow has invalid steps: indentation (and redundant dependency install/caching), which can break CI execution.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR refactors the pull request CI pipeline by consolidating the dependency/license static checks into the existing static analysis reusable workflow, removing the separate dependency-checks job.

Changes:

• Removed the static-dependency-checks job from the PR workflow.
• Deleted the dedicated reusable workflow for dependency checks.
• Added license checking and unused-dependency checking steps to the static analysis workflow.

File summaries

File	Description
.github/workflows/pull-request.yml	Removes the separate dependency-checks job so PRs rely on a single static-analysis job.
.github/workflows/_static-dependency-checks.yml	Deletes the now-redundant reusable workflow previously running dependency/license checks.
.github/workflows/_static-analysis.yml	Integrates license and composer-unused checks into the static analysis workflow (and adds composer install action usage).

Review details

Suppressed comments (1)

.github/workflows/_static-analysis.yml:43

• The dependency/license-check steps need to be indented under steps: (same issue as earlier in this file). While adjusting indentation, it’s also safer to use curl --fail/silent flags so the job fails cleanly if the download is unavailable.

    - name: License check
      run: |
        vendor/bin/license-checker check

    - name: Download Composer Unused

• Files reviewed: 3/3 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

.github/workflows/_static-analysis.yml currently has invalid YAML indentation under steps:, which will prevent the workflow from being parsed/executed.

Review details

Suppressed comments (1)

.github/workflows/_static-analysis.yml:14

• In this workflow, the list items under steps: are not indented, which makes the YAML invalid (the - uses: line is at the same indentation level as steps:). GitHub Actions will fail to parse this job.

    steps:
    - uses: actions/checkout@v4

    - name: Set up PHP
      uses: shivammathur/setup-php@v2

• Files reviewed: 12/12 changed files
• Comments generated: 0 new
• Review effort level: Lite