Add confirmation to issue reporter - #1749
Add confirmation to issue reporter#1749Eduardo Villalpando Mello (edvilme) wants to merge 4 commits into
Conversation
|
Can you add a screenshot to show what the ui or user flow looks like now? |
|
I like this additional step, but would like to hear if others have comments on the wordings. My thought is just that users may not be aware of this repo or don't know what it is, use maybe use some plain wordings like this will create an issue to help us investigate the issue you have with python environments or something? |
|
yeah I like stella's idea here on the wording. There was also maybe a way you could open the issue as a draft on github instead of filing it right away? maybe check the api for the issue filing to see if thats possible |
There was a problem hiding this comment.
🟢 Approval recommended
The refactor cleanly isolates the command logic, adds the intended confirmation/validation behavior, and is backed by updated unit tests covering key interaction paths.
Pull request overview
This PR improves the “Report Issue” flow by adding an explicit confirmation step before collecting diagnostics and opening VS Code’s issue reporter, and by extracting the command implementation into a dedicated feature module with updated unit tests.
Changes:
- Added a modal confirmation dialog before collecting environment/project details and opening the issue reporter.
- Added minimum description-length validation (3+ trimmed characters) to avoid accidental/empty submissions.
- Refactored the report-issue command implementation out of
src/extension.tsintosrc/features/reportIssue.ts, and updated unit tests accordingly.
File summaries
| File | Description |
|---|---|
| src/test/features/reportIssue.unit.test.ts | Reworked unit tests to use stubs for the new reportIssue flow (cancel paths, validation, confirmation, and error handling). |
| src/features/reportIssue.ts | New feature module encapsulating the report-issue UX, confirmation gate, and issue reporter invocation with localized strings and error handling. |
| src/extension.ts | Routes python-envs.reportIssue command to the new reportIssue(...) implementation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Added confirmation step to issue reporter to make intent clear to users and avoid accidental issue creation
This pull request makes improvements to user interaction and code organization in the
src/extension.tsfile. The main changes include adding a confirmation dialog before opening the issue reporter and making a small adjustment to the import order for better code clarity.User Experience Improvements:
Code Organization:
copyPathToClipboardfor improved consistency and readability in the import section.