Skip to content

Add confirmation to issue reporter - #1749

Open
Eduardo Villalpando Mello (edvilme) wants to merge 4 commits into
mainfrom
issue-reporter
Open

Add confirmation to issue reporter#1749
Eduardo Villalpando Mello (edvilme) wants to merge 4 commits into
mainfrom
issue-reporter

Conversation

@edvilme

@edvilme Eduardo Villalpando Mello (edvilme) commented Aug 31, 2026

Copy link
Copy Markdown
Contributor
image

Added confirmation step to issue reporter to make intent clear to users and avoid accidental issue creation

This pull request makes improvements to user interaction and code organization in the src/extension.ts file. The main changes include adding a confirmation dialog before opening the issue reporter and making a small adjustment to the import order for better code clarity.

User Experience Improvements:

  • Added a confirmation dialog that asks users to confirm before opening the issue reporter, reducing the chance of accidental submissions. The dialog appears after the user provides a description and only proceeds if they confirm.
  • Updated the description validation to require at least three characters, preventing empty or too-short submissions.

Code Organization:

  • Reordered the import of copyPathToClipboard for improved consistency and readability in the import section.

@edvilme Eduardo Villalpando Mello (edvilme) added feature-request Request for new features or functionality skip tests labels Aug 31, 2026
@StellaHuang95

Copy link
Copy Markdown
Contributor

Can you add a screenshot to show what the ui or user flow looks like now?

@StellaHuang95

Copy link
Copy Markdown
Contributor

I like this additional step, but would like to hear if others have comments on the wordings. My thought is just that users may not be aware of this repo or don't know what it is, use maybe use some plain wordings like this will create an issue to help us investigate the issue you have with python environments or something?

@eleanorjboyd

Copy link
Copy Markdown
Member

yeah I like stella's idea here on the wording. There was also maybe a way you could open the issue as a draft on github instead of filing it right away? maybe check the api for the issue filing to see if thats possible

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The refactor cleanly isolates the command logic, adds the intended confirmation/validation behavior, and is backed by updated unit tests covering key interaction paths.

Pull request overview

This PR improves the “Report Issue” flow by adding an explicit confirmation step before collecting diagnostics and opening VS Code’s issue reporter, and by extracting the command implementation into a dedicated feature module with updated unit tests.

Changes:

  • Added a modal confirmation dialog before collecting environment/project details and opening the issue reporter.
  • Added minimum description-length validation (3+ trimmed characters) to avoid accidental/empty submissions.
  • Refactored the report-issue command implementation out of src/extension.ts into src/features/reportIssue.ts, and updated unit tests accordingly.
File summaries
File Description
src/test/features/reportIssue.unit.test.ts Reworked unit tests to use stubs for the new reportIssue flow (cancel paths, validation, confirmation, and error handling).
src/features/reportIssue.ts New feature module encapsulating the report-issue UX, confirmation gate, and issue reporter invocation with localized strings and error handling.
src/extension.ts Routes python-envs.reportIssue command to the new reportIssue(...) implementation.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality skip tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants