chore(deps): bump minimatch from 5.1.9 to 10.2.6 - #1071
Conversation
5e09ba3 to
ab14067
Compare
|
Dependabot (@dependabot) rebase |
72fe2b8 to
3af8450
Compare
Bumps [minimatch](https://github.com/isaacs/minimatch) from 5.1.9 to 10.2.6. - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v5.1.9...v10.2.6) --- updated-dependencies: - dependency-name: minimatch dependency-version: 10.2.6 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
3af8450 to
20cf845
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Approved: the minimatch 10 named-export migration is covered and all current-head CI checks pass.
There was a problem hiding this comment.
🔵 Needs a closer look
Major-version dependency upgrades can introduce subtle runtime/tooling compatibility and compliance nuances that should be validated by a human reviewer.
Pull request overview
Updates the extension’s glob-matching dependency (minimatch) to a newer major version and adjusts the codebase to the package’s newer export style, while adding a small regression test around library-pattern deduplication.
Changes:
- Bump
minimatchfrom^5.1.9to^10.2.6(plus lockfile updates) and update third-party notices for the new license. - Update
libraryControllerto use the namedminimatchexport and exportdedupAlreadyCoveredPatternfor reuse. - Add a unit test validating deduplication behavior with a covered jar path.
File summaries
| File | Description |
|---|---|
| ThirdPartyNotices.txt | Updates the minimatch notice text to the Blue Oak license. |
| package.json | Bumps minimatch dependency version. |
| package-lock.json | Locks minimatch@10.2.6 and updated transitive dependencies. |
| src/controllers/libraryController.ts | Switches to named minimatch import; exports dedupAlreadyCoveredPattern. |
| extension.bundle.ts | Re-exports dedupAlreadyCoveredPattern for test access. |
| test/suite/libraryController.test.ts | Adds coverage for deduping already-covered library patterns. |
Review details
Suppressed comments (2)
ThirdPartyNotices.txt:506
- This notice includes a Markdown link target ("Notices") which is unlikely to be meaningful in a plain-text ThirdPartyNotices file; prefer plain text.
If anyone notifies you in writing that you have not
complied with [Notices](#notices), you can keep your
license by taking all practical steps to comply within 30
days after the notice. If you do not do so, your license
ThirdPartyNotices.txt:524
- This license text uses Markdown emphasis markers (...). Since ThirdPartyNotices.txt is plain text, remove the markup to avoid copying formatted artifacts into the notice.
**_As far as the law allows, this software comes as is,
without any warranty or condition, and no contributor
will be liable to anyone for any damages related to this
software or this license, under any kind of legal claim._**
- Files reviewed: 5/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🔵 Needs a closer look
It’s a major-version dependency upgrade with changed module export semantics and supply-chain considerations that warrants a final human verification pass.
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 0 new
- Review effort level: Lite
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
Approved: the minimatch 10 migration, minimum VS Code runtime, license notice, focused tests, packaging, independent review, and final-head CI checks all pass.
Bumps minimatch from 5.1.9 to 10.2.6.
Changelog
Sourced from minimatch's changelog.
... (truncated)
Commits
ded1bbd10.2.60215dfeupdate deps and lint10968eaimprove test for .. eating drive letters693c82310.2.57953af1do not allow .. to consume drive letter on Windows1caf918lint and format7783ed6ignore docs6d9b356update deps etcc36addb10.2.426b9002docs: add warning about ReDoSInstall script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.