Merge for 1.35.1 (pre-release) - #14764
Merged
Merged
Conversation
* Retry test VS Code acquisition and propagate failures * Normalize compile-and-test workflow line endings
* Add select translation unit command * Add translation unit fallback warnings * Improve translation unit selection feedback * Apply TypeScript formatting * Revert unrelated TypeScript formatting * Clean up unrelated TypeScript formatting
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
September 11, 2026 22:52
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Correct symlinked-workspace path handling and remove obsolete entries from checked-in localization catalogs.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Prepares the 1.35.1 pre-release with translation-unit selection, dependency updates, and more reliable VS Code acquisition in CI.
Changes:
- Adds translation-unit selection commands and LSP plumbing.
- Removes the obsolete
recursiveIncludes.reducesetting. - Adds acquisition retries, tests, CI coverage, and lockfile updates.
File summaries
| File | Description |
|---|---|
Themes/package-lock.json |
Updates transitive dependencies. |
ExtensionPack/package-lock.json |
Updates transitive dependencies. |
Extension/yarn.lock |
Updates dependency resolutions. |
Extension/ui/settings.html |
Removes the obsolete setting UI; localized UI catalogs also need cleanup. |
Extension/src/nativeStrings.json |
Adds translation-unit messages. |
Extension/src/LanguageServer/extension.ts |
Implements selection UI and path mapping; symlinked-workspace protocol paths need correction. |
Extension/src/LanguageServer/configurations.ts |
Removes the obsolete configuration field. |
Extension/src/LanguageServer/client.ts |
Adds LSP requests and notifications. |
Extension/package.nls.json |
Adds command localization and removes obsolete text; localized catalogs also need cleanup. |
Extension/package.json |
Registers the command and test script. |
Extension/.scripts/vscode.ts |
Adds acquisition retries and error handling. |
Extension/.scripts/vscode.test.mjs |
Tests acquisition behavior. |
Extension/.scripts/installAndCopyBinaries.ts |
Propagates installation failures. |
.github/workflows/job-compile-and-test.yml |
Runs acquisition tests in CI. |
.github/actions/package-lock.json |
Updates js-yaml. |
Review details
Files not reviewed (3)
- .github/actions/package-lock.json: Generated file
- ExtensionPack/package-lock.json: Generated file
- Themes/package-lock.json: Generated file
Suppressed comments (1)
Extension/src/LanguageServer/extension.ts:559
getEditorPathconverts the server's real path into the workspace/editor path for display, but this value is sent back to the language server as the selected translation unit. In a symlinked workspace that changes the candidate path the server returned underRootRealPath, so selection can fail or target a path the server does not recognize; keep the originalcandidatefor the protocol and useeditorPathonly for the Quick Pick UI.
translationUnit: editorPath
- Files reviewed: 11/15 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sean McManus (sean-mcmanus)
marked this pull request as ready for review
September 11, 2026 23:35
Colen Garoutte-Carson (Colengms)
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.