Update bundled LLVM tools for the shared bin layout - #14762
Draft
Colen Garoutte-Carson (Colengms) wants to merge 3 commits into
Draft
Update bundled LLVM tools for the shared bin layout#14762Colen Garoutte-Carson (Colengms) wants to merge 3 commits into
Colen Garoutte-Carson (Colengms) wants to merge 3 commits into
Conversation
Colen Garoutte-Carson (Colengms)
marked this pull request as ready for review
September 11, 2026 23:40
Colen Garoutte-Carson (Colengms)
requested a review
from a team
as a code owner
September 11, 2026 23:40
Copilot started reviewing on behalf of
Colen Garoutte-Carson (Colengms)
September 11, 2026 23:41
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
.gitignore does not cover the copied tool binaries, leaving untracked files that cleanup cannot remove.
Review tier: Lite
Findings: None
What changed in this PR
Updates bundled LLVM tools from Extension/LLVM/bin to Extension/bin while preserving legacy bootstrap compatibility.
Changes:
- Updated tool lookup and executable permissions.
- Normalized legacy and new binary layouts.
- Added cleanup and tests for both layouts.
| File | Description |
|---|---|
Extension/src/main.ts |
Uses shared bin paths for bundled tools. |
Extension/src/LanguageServer/settings.ts |
Checks bundled tool versions from bin. |
Extension/.scripts/vscode.test.mjs |
Tests legacy and new layouts. |
Extension/.scripts/copyExtensionBinaries.ts |
Copies both layouts into the shared directory. |
Extension/.scripts/clean.ts |
Removes stale LLVM directories. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Colen Garoutte-Carson (Colengms)
enabled auto-merge (squash)
September 11, 2026 23:55
Colen Garoutte-Carson (Colengms)
marked this pull request as draft
September 11, 2026 23:58
auto-merge was automatically disabled
September 11, 2026 23:58
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the extension to find clang-format and clang-tidy under
Extension/binafter their relocation from
Extension/LLVM/bin.The bundled-version check and Unix executable-permission setup now use the new
paths. The local binary bootstrap accepts both released extensions using the
legacy layout and extensions using the new layout, normalizing either into
bin. Prepublish cleanup also removes staleLLVMdirectories.This is coordinated with the native change that packages the LLVM tools beside
the VC runtime DLLs.
Validation:
git diff --checkpasses.