Add deterministic AI reporter qualification gates - #5999
Add deterministic AI reporter qualification gates#5999Sean Larkin (TheLarkInn) wants to merge 168 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Create the authoritative frontend reporter host before version selection, register global reporter controls, and preserve legacy output unless a non-legacy reporter is explicitly selected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Consume the repository experiment before Rush version selection, keep agent detection out of pre-major defaults, strip frontend-only controls before engine handoff, and preserve legacy verbosity compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
|
Independent Findings fixed
Corpus evidence
Validation
State / blockers
|
|
Combined deep review of current head
|
Stop reporter control scans at the pass-through separator and add an exactly-once frontend close contract across success, failure, and termination paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Keep reporter controls out of ts-command-line globals, gate incompatible engines before initialization, and enforce bounded signal and close-error behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Preserve unsupported custom reporter values until frontend ownership is unambiguous, and narrow emergency legacy stripping to the reporter selection flag. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Probe reporter ownership without requiring a value, then enforce strict reporter parsing only after frontend ownership is established. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
e30aa36 to
7159901
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Track explicit operation graph iteration identities across lifecycle events and isolate reporter totals, diagnostics, and output spools by watch cycle. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Track explicit operation graph iteration identities across lifecycle events and isolate reporter totals, diagnostics, and output spools by watch cycle. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d6318e80-5da9-4858-a147-817e8692f10e
Preserve R5B emergency sanitization, file-primary stderr ownership, and typed-sink flush behavior while retaining the four foundation regression cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Reporter-only subset of 1198341f54 for the posted presentation fixes. No Heft transport, demo, timers, output-observation guard, or manager drain changes are included. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Adapt a4cb979172 onto staged R5B 06bc7c5 after the shared-only human formatter lift. Preserve original host/parser changes and exclude downstream timers, wasRendered filtering, protected drain, R7 transport and initializer disposal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Preserve R8 qualification and reporter behavior while merging the corrected foundation host/parser parent without flattening side-branch history. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Retain the AI qualification branch history and incorporate the corrected R5B parent without replaying its older inherited stack. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Measure emitted UTF-8 including NDJSON delimiters, reserve final/log space across progress records, and qualify exact fallback context and remediation. Keep comparison baselines and the 50 percent/64 KiB thresholds unchanged; remove redundant AI metadata instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Prevent explicitly secret parameter values from reappearing through source labels, source paths or lower-classified template parameters. Preserve the original diagnostic and public context. The unchanged combined R8 corpus now passes all gates without AI, fixture or threshold changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Inherit the shared human-context privacy correction from the owning R5B parent. Preserve AI output, the original corpus, and all qualification thresholds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
26c2ac0 to
26a469f
Compare
Keep actual raw-byte measurements and all quality budgets unchanged. Drop only an unrendered metadata-only start acknowledgement superseded by the completed result; preserve every final field, supplied log reference, active-command status and ordered watch history. Align the three-pass file-backed qualification setup hook with the existing bounded 15-second integration allowance, without changing production deadlines or individual quality gates. Verified on actual Windows Node 24.11.1 and 26.7.0 plus Linux: the raw Windows legacy ratio falls from 51.4593 percent to 48.1435 percent, with final records and both baselines unchanged; 67 focused output/qualification/performance tests pass per platform. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
Preserve the complete R8 side history and the exact published Reporter package, including native Windows raw-byte acknowledgement coalescing, final and log-reference contracts, and all unchanged qualification and performance gates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
26a469f to
8ae2115
Compare
Run negative mutations and raw-byte capture in owned test workers instead of shared asynchronous prototype spies. Bound work and cleanup separately, join termination and temporary-file removal, and cover delayed, rejected, timed-out, and cancelled work without changing production reporters or qualification gates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4747f826-8c83-495d-80df-3d1168662e10
|
Refresh CI follow-up published at 88dcf1a: the two negative qualification mutations now run in isolated, owned test workers with finite work/termination budgets and joined cleanup, rather than shared asynchronous prototype spies. A controlled6.2-second delay reproduced the timeout/next-test recursion before the correction and passed afterward.96 output/qualification/performance tests passed on Linux22 and actualWindows24/26; all15 canonical gate results are identical to the pre-correction results. Production code, APIs, corpus fixtures, measurements and quality thresholds are unchanged. Fresh exact-head CI 34429599947 is running; no failed old-head run was blindly retried. |
|
Verified refreshed R8 head88dcf1ab77df857e1e641ba9aa42f3a54600b91e: first current-head CI34429599947 passed all six complete Windows/Linux workflows, including package-manager, README, second-checkout and repeated-cache stages. The test-only mutation isolation correction preserves actual negative-gate detection while joining worker termination and cleanup; production reporters, APIs, corpus fixtures, paths, measurements and all quality thresholds are unchanged. This completes R8 refresh validation, not approval or authorization to merge/release. |
Summary
Part of #5981.
Stack
copilot/reporter-r5b-demo-reporters)This PR does not copy or modify the telemetry projection from #5990. It applies the same producer-identity privacy boundary to presented reporter output and artifacts.
Corpus and gates
Corpus cases:
bootstrap-unsupported-node,configuration-invalid-json,input-unknown-project,dependency-package-manager,operation-build-failure,cache-restore-failure,network-auth-unauthorized,plugin-api-incompatible,logical-cancellation,internal-unexpected-error,success-no-warning, andsuccess-warning-only.External-service-shaped failures use stable canonical event fixtures. Returned results contain only case metadata, byte counts, booleans, and normalized hashes; absolute paths, private identities, and classified values are not stored.
Reproduce
cd libraries/reporter rushx build node scripts/runAiReporterQualification.jsThe script prints the versioned machine-readable result and exits nonzero when any blocking gate fails.
Selection boundary
getQualifiedAiReporterDecision()validates built-inCOPILOT_CLIdetection and configuredagentEnvironmentVariables, rejects absent or failed qualification results, and keepsRUSH_REPORTER=legacyauthoritative.It is intentionally not consumed by the Rush frontend in this PR. No environment variable automatically selects the AI reporter; the pre-major live path remains explicit
--reporteror repository-experiment opt-in, and no-opt-in behavior remains legacy.Validation
rush build --to @microsoft/rushrushx _phase:testinlibraries/reporter(314 tests)rushx _phase:testinlibraries/rush-librushx _phase:testinapps/rushCOPILOT_CLI=1legacy behavior andRUSH_REPORTER=legacyoverriderush checkrush change --verify --no-fetchNon-goals