-
Notifications
You must be signed in to change notification settings - Fork 710
Add direct Rush reporter demo path #5997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sean Larkin (TheLarkInn)
wants to merge
9
commits into
copilot/reporter-r5a-operation-adapter
from
copilot/reporter-r5b-demo-reporters
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8ae2115
Refresh corrected R5B reporters onto native-private trunk
TheLarkInn ba8c9f1
fix(rush): preserve discovery after malformed configuration
TheLarkInn 4b8db13
fix(rush): strip owned reporter controls from help
TheLarkInn 330fa91
test(reporter): preserve post-close artifact truthfulness
TheLarkInn 282b3f6
Merge reviewed R5A and lifecycle fixes into R5B presentation
TheLarkInn eab0577
fix(rush): preserve declared custom controls on help
TheLarkInn f6d0a61
Merge final command-aware foundation into R5B presentation
TheLarkInn e51e686
Merge declaration-aware help into final R5B core staging
TheLarkInn 3ce44c6
Preserve later full-log and root-help contracts in core staging
TheLarkInn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license. | ||
| // See LICENSE in the project root for license information. | ||
|
|
||
| import { EnvironmentVariableNames } from '@microsoft/rush-lib/lib/api/EnvironmentConfiguration'; | ||
|
|
||
| export function getRushPreviewVersion( | ||
| env: Record<string, string | undefined> = process.env | ||
| ): string | undefined { | ||
| return env[EnvironmentVariableNames.RUSH_PREVIEW_VERSION] || undefined; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in ba8c9f1. Legacy presentation ownership is determined even when loading rush.json fails, restoring the exact discovery line and blank line. Regressions cover malformed legacy, explicit/emergency legacy, help, custom/pass-through options, quiet mode, and explicit machine-output suppression. Descendants retain their caller-owned discovery writer and incompatible-engine stdout guard.
Published head:
3ce44c666a51b87ecfc8dbb07c74fb054bcbfc7b. Owning/combined local regression coverage passed; new hosted CI is being verified separately.